Gitiles
Code Review Sign In
gerrit.openfyde.cn / chromium.googlesource.com / chromiumos / platform / pinweaver / refs/heads/stabilize-14093.B
commitc64cfc2832d6b75b0198bcef6f4305e225c6e6c6[log] [tgz]
authorAndrey Pronin <apronin@google.com>Mon Jul 12 17:43:08 2021 +0300
committerAndrey Pronin <apronin@chromium.org>Wed Jul 14 08:57:51 2021 +0000
tree58c6fda2eb8e68e217d335240f03cb29c1d0ba48
parent8c9892c8b6e2986e2fa924a35d47daf7572c2a22 [diff]
tpm_storage: fix uninitialized use of entry in read_log_entries

This CL uses the correct pointer to entry when checking if the
resulting entry->counter is non-zero when looking for empty
entries.

BUG=b:193407596
TEST=make all

Change-Id: I321a089de2af18fe8aabc3c3e74023c8efb883e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/pinweaver/+/3021124
Reviewed-by: Aashay Shringarpure <aashay@google.com>
Commit-Queue: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
1 file changed
tree: 58c6fda2eb8e68e217d335240f03cb29c1d0ba48
  1. eal/
  2. pinweaver.c
  3. pinweaver.h
  4. pinweaver_eal.h
  5. pinweaver_types.h
  6. README.md
README.md

Common PinWeaver Code

This directory contains reference PinWeaver code that can be used across implementation platforms.

It consists of:

  • PinWeaver reference code:
    • pinweaver.h - PinWeaver embedded API definition
    • pinweaver.c - implementation
    • pinweaver_eal.h - API for Environment Abstraction Layer (EAL) used by PinWeaver
      • note that some types used in this API are platform-specific and are defined in eal/**/pinweaver_eal_types.h
    • pinweaver_types.h - header that is shared by PinWeaver implementation and PinWeaver clients that call it through platform-specific interface.
  • Environment Abstraction Layer (EAL) implementations - in eal/ folder
    • eal/cr50 - implementation for cr50
      • pinweaver_eal_types.h - cr50-specific EAL API types
      • pinweaver_eal.c - cr50 implementation of EAL
    • eal/tpm_storage - implementation for platforms that use TPM as PinWeaver data storage
      • pinweaver_eal_types.h - TPM-storage-specific EAL API types
      • pinweaver_eal_tpm.h - additional EAL functions required by TPM storage
      • pinweaver_eal_linux.c - implementation of non-storage EAL methods for Linux case
      • tpm_storage_stubs.c - empty implementation of storage EAL methods
      • tpm_storage.c - implementation of storage EAL methods on top of TSS
      • mini_trunks/ - mini-TSS (TPM client software stack) used by TPM storage implementation
        • created from trunks TSS used by ChromeOS reduced to the minimal required set of TPM commands and ported from C++ to C
        • relies on pinweaver_eal.h + pinweaver_eal_tpm.h EAL methods
        • TSS API is defined in tss.h + *authorization_delegate.h

A platform implementation that uses TPM storage EAL option needs to implement all EAL methods implemented in pinweaver_eal_linux.c (or use it as-is, if Linux compatible).