Gitiles
Code Review Sign In
gerrit.openfyde.cn / chromium.googlesource.com / chromiumos / platform / pinweaver / 2150ddb0c25bb06a20cbdb036f186192d8fe2463
commit2150ddb0c25bb06a20cbdb036f186192d8fe2463[log] [tgz]
authorHoward Yang <hcyang@google.com>Fri Feb 03 17:41:06 2023 +0800
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Feb 04 04:59:16 2023 +0000
tree9731660752eb5829d129ad5577de3bb190859e2d
parentaadc19b0445b5bc0d1cf9fdc2d87460893194d06 [diff]
Never write to response before reading request

As request and response might share the same buffer, we should finish
all reads from the request before writing to response.
pw_handle_generate_pk violates this rule. Fix it so it won't
accidentally overwrite request data.

BUG=b:267728085
TEST=pinweaver_client biometrics_selftest on betty

Change-Id: I3718eb5ce596f75688569609c06fd3e22b01b38a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/pinweaver/+/4221101
Commit-Queue: Howard Yang <hcyang@google.com>
Tested-by: Howard Yang <hcyang@google.com>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Yi Chou <yich@google.com>
1 file changed
tree: 9731660752eb5829d129ad5577de3bb190859e2d
  1. eal/
  2. fuzzer/
  3. BUILD.gn
  4. DIR_METADATA
  5. LICENSE
  6. OWNERS
  7. pinweaver.c
  8. pinweaver.h
  9. pinweaver_eal.h
  10. pinweaver_types.h
  11. PRESUBMIT.cfg
  12. README.md
README.md

Common PinWeaver Code

This directory contains reference PinWeaver code that can be used across implementation platforms.

It consists of:

  • PinWeaver reference code:
    • pinweaver.h - PinWeaver embedded API definition
    • pinweaver.c - implementation
    • pinweaver_eal.h - API for Environment Abstraction Layer (EAL) used by PinWeaver
      • note that some types used in this API are platform-specific and are defined in eal/**/pinweaver_eal_types.h
    • pinweaver_types.h - header that is shared by PinWeaver implementation and PinWeaver clients that call it through platform-specific interface.
  • Environment Abstraction Layer (EAL) implementations - in eal/ folder
    • eal/cr50 - implementation for cr50
      • pinweaver_eal_types.h - cr50-specific EAL API types
      • pinweaver_eal.c - cr50 implementation of EAL
    • eal/tpm_storage - implementation for platforms that use TPM as PinWeaver data storage
      • pinweaver_eal_types.h - TPM-storage-specific EAL API types
      • pinweaver_eal_tpm.h - additional EAL functions required by TPM storage
      • pinweaver_eal_linux.c - implementation of non-storage EAL methods for Linux case
      • tpm_storage_stubs.c - empty implementation of storage EAL methods
      • tpm_storage.c - implementation of storage EAL methods on top of TSS
      • mini_trunks/ - mini-TSS (TPM client software stack) used by TPM storage implementation
        • created from trunks TSS used by ChromeOS reduced to the minimal required set of TPM commands and ported from C++ to C
        • relies on pinweaver_eal.h + pinweaver_eal_tpm.h EAL methods
        • TSS API is defined in tss.h + *authorization_delegate.h

A platform implementation that uses TPM storage EAL option needs to implement all EAL methods implemented in pinweaver_eal_linux.c (or use it as-is, if Linux compatible).