Gitiles
Code Review Sign In
gerrit.openfyde.cn / chromium.googlesource.com / chromiumos / platform / pinweaver / 19fa7b1d5ae0953fc7bbef81ceb87ab0fbee299f
commit19fa7b1d5ae0953fc7bbef81ceb87ab0fbee299f[log] [tgz]
authorHoward Yang <hcyang@google.com>Wed Jan 11 13:36:06 2023 +0800
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 17 16:29:33 2023 +0000
tree85312236d520631891b0cccedef1f7598979d6f7
parent1d4c5856b02e048c7cdeeeac1004249b459ae2fe [diff]
pinweaver: Adjust v2 eal interfaces

Rename storage getter/setter eal functions to be consistent with
existing ones. Remove pw_ba_pk_status param from the getter eal and use
the return code to determine the status instead.

BUG=b:248209280
TEST=pinweaver_client biometrics_selftest
TEST=tast run $DUT hwsec.PINWeaver*

Cq-Depend: chromium:4154170
Change-Id: Ied445501881d6b862b942cfbcffa29c7d0a0f610
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/pinweaver/+/4154150
Reviewed-by: Edward Hill <ecgh@chromium.org>
Tested-by: Howard Yang <hcyang@google.com>
Commit-Queue: Howard Yang <hcyang@google.com>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
4 files changed
tree: 85312236d520631891b0cccedef1f7598979d6f7
  1. eal/
  2. fuzzer/
  3. BUILD.gn
  4. DIR_METADATA
  5. LICENSE
  6. OWNERS
  7. pinweaver.c
  8. pinweaver.h
  9. pinweaver_eal.h
  10. pinweaver_types.h
  11. PRESUBMIT.cfg
  12. README.md
README.md

Common PinWeaver Code

This directory contains reference PinWeaver code that can be used across implementation platforms.

It consists of:

  • PinWeaver reference code:
    • pinweaver.h - PinWeaver embedded API definition
    • pinweaver.c - implementation
    • pinweaver_eal.h - API for Environment Abstraction Layer (EAL) used by PinWeaver
      • note that some types used in this API are platform-specific and are defined in eal/**/pinweaver_eal_types.h
    • pinweaver_types.h - header that is shared by PinWeaver implementation and PinWeaver clients that call it through platform-specific interface.
  • Environment Abstraction Layer (EAL) implementations - in eal/ folder
    • eal/cr50 - implementation for cr50
      • pinweaver_eal_types.h - cr50-specific EAL API types
      • pinweaver_eal.c - cr50 implementation of EAL
    • eal/tpm_storage - implementation for platforms that use TPM as PinWeaver data storage
      • pinweaver_eal_types.h - TPM-storage-specific EAL API types
      • pinweaver_eal_tpm.h - additional EAL functions required by TPM storage
      • pinweaver_eal_linux.c - implementation of non-storage EAL methods for Linux case
      • tpm_storage_stubs.c - empty implementation of storage EAL methods
      • tpm_storage.c - implementation of storage EAL methods on top of TSS
      • mini_trunks/ - mini-TSS (TPM client software stack) used by TPM storage implementation
        • created from trunks TSS used by ChromeOS reduced to the minimal required set of TPM commands and ported from C++ to C
        • relies on pinweaver_eal.h + pinweaver_eal_tpm.h EAL methods
        • TSS API is defined in tss.h + *authorization_delegate.h

A platform implementation that uses TPM storage EAL option needs to implement all EAL methods implemented in pinweaver_eal_linux.c (or use it as-is, if Linux compatible).