Remove "race condition TODO" comments
This race was already solved when we added event synchronization
using Event_Sync_State() to EvdevRead().
Event_Read() will force a resynchronization if it detects any input
events arrived during a previous call to Event_Sync_State().
BUG=chrome-os-partner:13951
TEST=none (no functional change)
Original-Change-Id: I85e47b92a90ffcbce85dfe84a39dac8ea6c55cc9
Reviewed-on: https://gerrit.chromium.org/gerrit/33414
Reviewed-by: Chung-yih Wang <cywang@chromium.org>
Commit-Ready: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
(cherry picked from commit bdd876f22602501cd2a2f593e0a0f588ed253286)
Change-Id: I0c29e10f6b53257b4cb750d6dbd81e12d7034d84
Reviewed-on: https://gerrit.chromium.org/gerrit/34178
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
diff --git a/src/libevdev.c b/src/libevdev.c
index 064236b..1f1c5e8 100644
--- a/src/libevdev.c
+++ b/src/libevdev.c
@@ -175,13 +175,6 @@
Event_To_String(EV_REL, i));
}
- /*
- * TODO(djkurtz): Solve the race condition between MT slot initialization
- * from absinfo, and incoming/lost input events.
- * Specifically, if kernel driver sends MT_SLOT event between absinfo
- * probe and when we start listening for input events.
- */
-
len = ioctl(fd, EVIOCGBIT(EV_ABS, sizeof(info->abs_bitmask)),
info->abs_bitmask);
if (len < 0) {
diff --git a/src/libevdev_event.c b/src/libevdev_event.c
index 8b10cd6..c43abc1 100644
--- a/src/libevdev_event.c
+++ b/src/libevdev_event.c
@@ -263,13 +263,6 @@
return !Success;
}
- /*
- * TODO(djkurtz): Solve the race condition between MT slot initialization
- * from absinfo, and incoming/lost input events.
- * Specifically, if kernel driver sends MT_SLOT event between absinfo
- * probe and when we start listening for input events.
- */
-
for (i = ABS_X; i <= ABS_MAX; i++) {
if (TestBit(i, device->info.abs_bitmask)) {
struct input_absinfo* absinfo = &device->info.absinfo[i];