commit 73b365c4121c82c090eda0f3adf036aa049949d7
author Alan Green <avg@google.com> Wed May 05 20:22:37 2021 +1000
committer Commit Bot <commit-bot@chromium.org> Fri May 07 02:12:36 2021 +0000
tree 8eca3cbdccd89f2bcd70b606d873be3e216e978b
parent da2318b30421ed66ec9d953460c20cdb43a39b17

scripts: remove lint violations

Fixes lint found by "cros lint" for all bash scripts in the scripts
directory.

BUG=b:187250385
TEST=Manual

Change-Id: I17f2a2caa4d0f10254461f08a1ef1781fa5a877b
Reviewed-on: https://chrome-internal-review.googlesource.com/c/chromeos/platform/hps-firmware/+/3811025
Commit-Queue: Alan Green <avg@google.com>
Tested-by: Alan Green <avg@google.com>
Reviewed-by: Dan Callaghan <dcallagh@google.com>
Reviewed-by: David Lattimore <dml@google.com>

scripts/check-binary-sizes

diff --git a/scripts/check-binary-sizes b/scripts/check-binary-sizes
index 596dc65..b550eaa 100755
--- a/scripts/check-binary-sizes
+++ b/scripts/check-binary-sizes
@@ -1,11 +1,15 @@
 #!/bin/bash
 
+# Copyright 2021 The Chromium OS Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
 # Builds code and prints binary sizes. For now, this only reports sizes of MCU
 # binaries as that is by far the most space-constrained.
 
-PROJECT_ROOT=$(realpath $(dirname ${BASH_SOURCE[0]})/..)
+PROJECT_ROOT=$(realpath "$(dirname "${BASH_SOURCE[0]}")"/..)
 
-source $PROJECT_ROOT/environment
+source "${PROJECT_ROOT}/environment"
 
 set -e
 STAGE0="${PROJECT_ROOT}/mcu_rom/stage0/target/thumbv6m-none-eabi/release/stage0.bin"
@@ -13,32 +17,32 @@
 APPLICATION="${PROJECT_ROOT}/mcu_rom/stm32g0_application/target/thumbv6m-none-eabi/release/stm32g0_application.bin"
 (
     cd "${PROJECT_ROOT}/mcu_rom/stage0"
-    cargo +$RUST_VERSION build --release
+    cargo "+${RUST_VERSION}" build --release
     arm-none-eabi-objcopy \
         -O binary \
         target/thumbv6m-none-eabi/release/stage0 \
-        "$STAGE0"
+        "${STAGE0}"
 )
 (
     cd "${PROJECT_ROOT}/mcu_rom/stage1"
-    cargo +$RUST_VERSION build --release
+    cargo "+${RUST_VERSION}" build --release
     arm-none-eabi-objcopy \
         -O binary \
         target/thumbv6m-none-eabi/release/stage1 \
-        "$STAGE1"
+        "${STAGE1}"
 )
 (
     cd "${PROJECT_ROOT}/mcu_rom/stm32g0_application"
-    cargo +$RUST_VERSION build --release
+    cargo "+${RUST_VERSION}" build --release
     arm-none-eabi-objcopy \
         -O binary \
         target/thumbv6m-none-eabi/release/stm32g0_application \
-        "$APPLICATION"
+        "${APPLICATION}"
 )
 echo
-STAGE0_SIZE=$(stat --printf='%s' "$STAGE0")
-STAGE1_SIZE=$(stat --printf='%s' "$STAGE1")
-APPLICATION_SIZE=$(stat --printf='%s' "$APPLICATION")
+STAGE0_SIZE=$(stat --printf='%s' "${STAGE0}")
+STAGE1_SIZE=$(stat --printf='%s' "${STAGE1}")
+APPLICATION_SIZE=$(stat --printf='%s' "${APPLICATION}")
 echo "Stage0: ${STAGE0_SIZE} bytes"
 echo "Stage1: ${STAGE1_SIZE} bytes"
 echo "Application: ${APPLICATION_SIZE} bytes"