commit 3566ac7eb96411ee0e9bf728fa0d30e4ef1435e8
author Yu-An Wang <wyuang@google.com> Mon Nov 07 17:49:32 2022 +0800
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 10 05:33:03 2022 +0000
tree d39ba19a33f37410fb09e99f5f9a3c6bdc58211e
parent 0477cbf7f321e0bb8a8363e8507cea928ea1dfa5

rust: enable `Command` related tests in CQ

Tests invoking `Command` are observed flaky on non-native platform so
we temporarily disabled them in CQ.  This CL enables them only in x86
CQ to verify if they are actually stable in native platforms.

BUG=b:257914405
TEST=cros_run_unit_tests --packages factory_installer --board brya

Cq-Depend: chromium:4003487
Change-Id: I401a4472703fa17361fe29a18677541836d06822
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/factory_installer/+/4005820
Reviewed-by: Phoebe Wang <phoebewang@chromium.org>
Commit-Queue: Yu-An Wang <wyuang@google.com>
Tested-by: Yu-An Wang <wyuang@google.com>

rust/src/tools/ap_ro_hash.rs

diff --git a/rust/src/tools/ap_ro_hash.rs b/rust/src/tools/ap_ro_hash.rs
index caa5ce6..d6713c1 100644
--- a/rust/src/tools/ap_ro_hash.rs
+++ b/rust/src/tools/ap_ro_hash.rs
@@ -1,4 +1,4 @@
-// Copyright 2022 The ChromiumOS Authors.
+// Copyright 2022 The ChromiumOS Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -269,9 +269,6 @@
     Ok(calculate_hash(&bios_file, &sections).context("Failed to calculate AP RO hash.")?)
 }
 
-// TODO(b/244122974): Disabled since test timeout in CQ. Consider to test it with IO stream instead
-// of reading file directly.
-#[cfg(not(feature = "cq-test"))]
 #[cfg(test)]
 mod tests {
     use crate::tools::ap_ro_hash;

rust/src/utils/process_utils.rs

diff --git a/rust/src/utils/process_utils.rs b/rust/src/utils/process_utils.rs
index 48bff52..b782dc3 100644
--- a/rust/src/utils/process_utils.rs
+++ b/rust/src/utils/process_utils.rs
@@ -1,4 +1,4 @@
-// Copyright 2022 The Chromium OS Authors. All rights reserved.
+// Copyright 2022 The ChromiumOS Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -42,7 +42,6 @@
     }
 }
 
-#[cfg(not(feature = "cq-test"))]
 #[cfg(test)]
 mod tests {
     use crate::utils::process_utils::StringOutput;