Fix raising exception with format string.
Some exception is raised as "raise ValueError('error: %s', s)" when the
caller intended to do a format string like "raise ValueError('error: %s'
% s)". Fix them.
This is caught by newer version of pylint under raising-format-tuple:
Exception arguments suggest string formatting might be intended.
Also fixed that subprocess.CalledProcessError doesn't accept a message
argument, and change usage to use other exception as appropiate.
BUG=b:73868308
TEST=make test
Change-Id: Id0667fdf852c8bd176acbd60c51f44077eb3c5f8
Reviewed-on: https://chromium-review.googlesource.com/936352
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
diff --git a/py/gooftool/commands.py b/py/gooftool/commands.py
index e96589a..6b80089 100755
--- a/py/gooftool/commands.py
+++ b/py/gooftool/commands.py
@@ -652,7 +652,7 @@
elif method == 'cpfe':
report_upload.CpfeUpload(target_path, pipes.quote(param))
else:
- raise Error('unknown report upload method %r', method)
+ raise Error('unknown report upload method %r' % method)
@Command('finalize',