Change naming of constants in test.env.paths. (DATA_DIR)
This change the naming of constants in test.env.paths for directories
/var/factory/*, according to go/GoofyFHS.
Changes:
* GetFactoryRoot() -> DATA_DIR
* GetLogRoot() -> DATA_LOG_DIR
* GetStateRoot() -> DATA_STATE_DIR
* GetTestDataRoot() -> DATA_TESTS_DIR
* GetConsoleLogPath() -> CONSOLE_LOG_PATH
* GetFactoryLogPath() -> FACTORY_LOG_PATH
* Fix the usage of DATA_*DIR to do makedirs explicitly when needed,
since the original Get*Root() would do makedirs implicitly when
called.
Also fix some lint warnings.
BUG=None
TEST=make test
Change-Id: Idec29b28b5efbdd76e3590e6db341d2d759f3a4f
Reviewed-on: https://chromium-review.googlesource.com/515262
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>
diff --git a/py/gooftool/commands.py b/py/gooftool/commands.py
index cdadb88..36b1cd0 100755
--- a/py/gooftool/commands.py
+++ b/py/gooftool/commands.py
@@ -608,7 +608,7 @@
# Intentionally ignoring dotfiles in EVENT_LOG_DIR.
tar_cmd = 'cd %s ; tar cJf %s *' % (event_log.EVENT_LOG_DIR, target_path)
- tar_cmd += ' %s' % paths.GetFactoryLogPath()
+ tar_cmd += ' %s' % paths.FACTORY_LOG_PATH
if add_file:
for f in add_file:
# Require absolute paths since the tar command may change the