goofy.py: Fix some lint error
BUG=None
TEST=make smartlint
TEST=make test
Change-Id: I69315bd828b23851840c098680734d3df4ee02c1
Reviewed-on: https://chromium-review.googlesource.com/538456
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
diff --git a/py/tools/ghost.py b/py/tools/ghost.py
index 72c4d16..dedce7d 100755
--- a/py/tools/ghost.py
+++ b/py/tools/ghost.py
@@ -641,7 +641,7 @@
if self._sock in rd:
buf = self._sock.Recv(_BUFSIZE)
- if len(buf) == 0:
+ if not buf:
raise RuntimeError('connection terminated')
_ProcessBuffer(buf)
except Exception as e:
@@ -689,7 +689,7 @@
if self._sock in rd:
ret = self._sock.Recv(_BUFSIZE)
- if len(ret) == 0:
+ if not ret:
raise RuntimeError('connection terminated')
try:
@@ -747,7 +747,7 @@
with open(self._file_op[1], 'rb') as f:
while True:
data = f.read(_BLOCK_SIZE)
- if len(data) == 0:
+ if not data:
break
self._sock.Send(data)
except Exception as e:
@@ -779,7 +779,7 @@
rd, unused_wd, unused_xd = select.select([self._sock], [], [])
if self._sock in rd:
buf = self._sock.Recv(_BLOCK_SIZE)
- if len(buf) == 0:
+ if not buf:
break
f.write(buf)
except socket.error as e:
@@ -809,13 +809,13 @@
if self._sock in rd:
data = self._sock.Recv(_BUFSIZE)
- if len(data) == 0:
+ if not data:
raise RuntimeError('connection terminated')
src_sock.send(data)
if src_sock in rd:
data = src_sock.recv(_BUFSIZE)
- if len(data) == 0:
+ if not data:
break
self._sock.Send(data)
except Exception as e:
@@ -991,7 +991,7 @@
data = self._sock.Recv(_BUFSIZE)
# Socket is closed
- if len(data) == 0:
+ if not data:
break
self.ParseMessage(data, self._register_status != SUCCESS)
@@ -1142,7 +1142,7 @@
except Queue.Empty:
pass
else:
- if type(obj) is not str:
+ if not isinstance(obj, str):
self._queue.put(obj)
elif obj == 'pause':
logging.info('LAN Discovery: paused')
@@ -1195,7 +1195,7 @@
except Queue.Empty:
pass
else:
- if type(addr) == tuple and addr not in self._overlord_addrs:
+ if isinstance(addr, tuple) and addr not in self._overlord_addrs:
logging.info('LAN Discovery: got overlord address %s:%d', *addr)
self._overlord_addrs.append(addr)