commit 9cd93ea21416e8865302fb3452c96e5ff30f9944
author Fei Shao <fshao@chromium.org> Tue Jun 16 18:31:22 2020 +0800
committer Commit Bot <commit-bot@chromium.org> Fri Jun 19 14:54:14 2020 +0000
tree e1dde58b637c11b65ae9f953a796f21ec70421a5
parent a161e750ce3a4e3dc0437bb982c4d9772d928e14

pylint: Fix consider-using-sys-exit lint error

It's not recommended to use quit() or exit() outside of the interpreter,
because both of them rely on "site" module.

A better practice would be using sys.exit() which has the exact same behavior.

BUG=b:158811392
TEST=make lint && make test

Change-Id: I0e41ca5388a0659db4935b40b820c1b358fc94c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/factory/+/2247965
Reviewed-by: Yilin Yang (kerker) <kerker@chromium.org>
Tested-by: Fei Shao <fshao@chromium.org>
Commit-Queue: Fei Shao <fshao@chromium.org>

py/instalog/cli.py

diff --git a/py/instalog/cli.py b/py/instalog/cli.py
index a0c2729..14f9c44 100755
--- a/py/instalog/cli.py
+++ b/py/instalog/cli.py
@@ -98,7 +98,7 @@
     # Read config file.
     config_path = self._LocateConfigFile(args.config)
     if config_path is None:
-      exit('No config file found')
+      sys.exit('No config file found')
     with open(config_path) as f:
       config = yaml.load(f)
     self._CheckDataDir(config)

py/instalog/strptime_unittest.py

diff --git a/py/instalog/strptime_unittest.py b/py/instalog/strptime_unittest.py
index 6739c37..14d18f3 100755
--- a/py/instalog/strptime_unittest.py
+++ b/py/instalog/strptime_unittest.py
@@ -94,7 +94,7 @@
     if not fn:
       print('%s: [<time/datetime> [patched]]' % sys.argv[0])
     if fn:
-      exit(0 if StrptimeRun(fn, patched) else 1)
+      sys.exit(0 if StrptimeRun(fn, patched) else 1)
 
   else:
     unittest.main()

py/tools/chrome_debugger.py

diff --git a/py/tools/chrome_debugger.py b/py/tools/chrome_debugger.py
index 8d48800..2cfa7c5 100755
--- a/py/tools/chrome_debugger.py
+++ b/py/tools/chrome_debugger.py
@@ -127,7 +127,7 @@
 
 if __name__ == '__main__':
   if len(sys.argv) != 3:
-    exit('Usage: %s method_name json_params' % sys.argv[0])
+    sys.exit('Usage: %s method_name json_params' % sys.argv[0])
 
   chrome = ChromeRemoteDebugger()
   pages = chrome.GetPages('page')

py/tools/tiny_par.py

diff --git a/py/tools/tiny_par.py b/py/tools/tiny_par.py
index ccb8be9..b33aff0 100755
--- a/py/tools/tiny_par.py
+++ b/py/tools/tiny_par.py
@@ -39,6 +39,7 @@
 import logging
 import os
 import shutil
+import sys
 import tempfile
 import zipfile
 
@@ -161,7 +162,7 @@
   logging.basicConfig(level=logging.WARNING - 10 * (args.verbose or 0))
 
   if not args.modules:
-    exit('ERROR: Need at least one module (-m).')
+    sys.exit('ERROR: Need at least one module (-m).')
 
   init_modules = ['__init__']
   if args.extra_init:

py/tools/yaml2json.py

diff --git a/py/tools/yaml2json.py b/py/tools/yaml2json.py
index c0b073e..f68e48a 100755
--- a/py/tools/yaml2json.py
+++ b/py/tools/yaml2json.py
@@ -31,7 +31,7 @@
 
 def main():
   if not 1 < len(sys.argv) < 4:
-    exit('Usage: %s input [output]' % sys.argv[0])
+    sys.exit('Usage: %s input [output]' % sys.argv[0])
   in_file = sys.argv[1]
   out_file = sys.argv[2] if len(sys.argv) > 2 else (
       ConvertYAMLPathToJSONPath(in_file))

py/utils/pygpt.py

diff --git a/py/utils/pygpt.py b/py/utils/pygpt.py
index bd60abf..3079f02 100755
--- a/py/utils/pygpt.py
+++ b/py/utils/pygpt.py
@@ -1628,7 +1628,7 @@
   except Exception as e:
     if args.verbose or args.debug:
       logging.exception('Failure in command [%s]', args.command)
-    exit('ERROR: %s: %s' % (args.command, str(e) or 'Unknown error.'))
+    sys.exit('ERROR: %s: %s' % (args.command, str(e) or 'Unknown error.'))
 
 
 if __name__ == '__main__':