gooftool: set cr50 board id in finalize as early as possible.
1. The engineer of cr50 recommend that board id should be set as early as
possible in the factory process.
2. Setting board id by a pytest is not a proper solution because we can't
guarantee whether partner will do any change on itor not.
3. Finalize in the GRT is the more safe place because we define that
partner can't modify it. Thus we should put Cr50SetBoardId in the
first place of finalize.
4. Verify in the finalize intends to catch any errors before doing
any non-revertable changes. But check points in Verify actually can't figure
out any error related to RLZ code and build phase (which are factors of
cr50 board id) therefore putting Cr50SetBoardId before or after Verify
is no difference.
BUG=b:73905232
TEST=None
Change-Id: Iba9655a235d857eb9917bb0f03f37317ac7145e4
Reviewed-on: https://chromium-review.googlesource.com/946308
Commit-Ready: Marco Chen <marcochen@chromium.org>
Tested-by: Marco Chen <marcochen@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>
diff --git a/py/gooftool/commands.py b/py/gooftool/commands.py
index c64bca0..42c3b3a 100755
--- a/py/gooftool/commands.py
+++ b/py/gooftool/commands.py
@@ -681,8 +681,8 @@
- Uploads system logs & reports
- Wipes the testing kernel, rootfs, and stateful partition
"""
- Verify(options)
Cr50SetBoardId(options)
+ Verify(options)
Cr50ResetState(options)
LogSourceHashes(options)
UntarStatefulFiles(options)