commit 4c74ca04c559853dd3804ab4243ed64ef0ec6d6f
author Yilin Yang <kerker@google.com> Wed Jul 22 16:12:01 2020 +0800
committer Commit Bot <commit-bot@chromium.org> Thu Jul 23 09:24:51 2020 +0000
tree fb70c943734ff01e4ca424f55e9dd16aaccb1a4d
parent dff0fd81e4ae633741672729066ac40ce15ee1ed

pylint: Fix unnecessary-comprehension lint error

We can make use of the constructor of `list()` and `dict()` to avoid
unnecessary comprehension.

BUG=b:158811392
TEST=make test, make lint

Change-Id: Id4c2f81a7e60a9c7a0168f793db6e198e43dc76b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/factory/+/2312019
Reviewed-by: Fei Shao <fshao@chromium.org>
Tested-by: Yilin Yang (kerker) <kerker@chromium.org>
Commit-Queue: Yilin Yang (kerker) <kerker@chromium.org>

py/utils/pygpt.py

diff --git a/py/utils/pygpt.py b/py/utils/pygpt.py
index bb2e27b..b490241 100755
--- a/py/utils/pygpt.py
+++ b/py/utils/pygpt.py
@@ -280,7 +280,7 @@
     else:
       self.Zero()
 
-    all_names = [f for f in self.__slots__]
+    all_names = list(self.__slots__)
     for name, value in kargs.items():
       if name not in all_names:
         raise GPTError('%s does not support keyword arg <%s>.' %