commit 4b75502939937aab9b76faf61e3933fe9c3ffde7
author Wei-Han Chen <stimim@google.com> Wed Jan 04 10:51:52 2017 +0800
committer Wei-Han Chen <stimim@chromium.org> Thu Jan 05 11:14:52 2017 +0000
tree c7a60951c96b41eb8235fc383a927cad7d2fb573
parent 92abd2a52ba9998832d0546e393ea0f6998689b5

gooftool: avoid using --add-file option of tar

There is a bug in tar command that --add-file is not working now:
https://lists.libreplanet.org/archive/html/bug-tar/2016-11/msg00013.html

remove --add-file options in gooftool.

BUG=None
TEST=manual

Change-Id: I2b12da01a4ab705c9669443d20306a1850d390b3
Reviewed-on: https://chromium-review.googlesource.com/424518
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

py/gooftool/commands.py

diff --git a/py/gooftool/commands.py b/py/gooftool/commands.py
index 1a77672..0e3c125 100755
--- a/py/gooftool/commands.py
+++ b/py/gooftool/commands.py
@@ -598,7 +598,7 @@
 
   # Intentionally ignoring dotfiles in EVENT_LOG_DIR.
   tar_cmd = 'cd %s ; tar cJf %s *' % (event_log.EVENT_LOG_DIR, target_path)
-  tar_cmd += ' --add-file %s' % paths.GetFactoryLogPath()
+  tar_cmd += ' %s' % paths.GetFactoryLogPath()
   if add_file:
     for f in add_file:
       # Require absolute paths since the tar command may change the
@@ -607,7 +607,7 @@
         raise Error('Not an absolute path: %s' % f)
       if not os.path.exists(f):
         raise Error('File does not exist: %s' % f)
-      tar_cmd += ' --add-file %s' % pipes.quote(f)
+      tar_cmd += ' %s' % pipes.quote(f)
   cmd_result = Shell(tar_cmd)
 
   if ((cmd_result.status == 1) and