commit 46a3fc92b31423cf07ce56c2109cbe86a3a7bb8f
author Wei-Ning Huang <wnhuang@google.com> Tue Oct 06 02:35:27 2015 +0800
committer chrome-bot <chrome-bot@chromium.org> Tue Oct 13 05:29:14 2015 -0700
tree d5b5420d4fadd5874aa8693c111544d097ca2ca8
parent de5230b4f6ced067733e38968e5dada850f26ae8

overlord: download: correctly detect read access error

The stat call works on readonly file and thus won't detect permission
denied error. Open the file for reading directly instead to correctly
detect it.

BUG=chromium:517520
TEST=test with ovl command in CL:291940

Change-Id: If4f98d68f132f302b10bbf90d640eab3818c4cca
Reviewed-on: https://chromium-review.googlesource.com/304071
Commit-Ready: Wei-Ning Huang <wnhuang@chromium.org>
Tested-by: Wei-Ning Huang <wnhuang@chromium.org>
Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org>

py/tools/ghost.py

diff --git a/py/tools/ghost.py b/py/tools/ghost.py
index ef6c91e..91ae721 100755
--- a/py/tools/ghost.py
+++ b/py/tools/ghost.py
@@ -869,8 +869,9 @@
       filepath = os.path.join(os.getenv('HOME', '/tmp'), filepath)
 
     try:
-      os.stat(filepath)
-    except OSError as e:
+      with open(filepath, 'r') as f:
+        pass
+    except Exception as e:
       return self.SendResponse(msg, str(e))
 
     self.SpawnGhost(self.FILE, params['sid'],