commit 3404a091732b7a110aec1fccc2d581fa60f759c7
author Shawn Nematbakhsh <shawnn@google.com> Mon Jan 28 16:49:09 2013 -0800
committer ChromeBot <chrome-bot@google.com> Wed Jan 30 12:29:22 2013 -0800
tree bb818ac437723690975509304860a134887bca72
parent e3fc5d988215c5cf1e0d91207fd7ff02a8ed7728

gooftool / report_upload: Fix CPFE upload method.

CPFE returns success / fail strings different than expected. Also, "&"
in URLs must be escaped.

BUG=chromium-os:38322
TEST=manual. Complete finalize step successfully w/ CPFE upload method.

Change-Id: I16531c3c6cc88cdb39e19fbde03e4bc8aff6b586
Reviewed-on: https://gerrit.chromium.org/gerrit/42189
Reviewed-by: Jon Salz <jsalz@chromium.org>
Tested-by: Shawn Nematbakhsh <shawnn@chromium.org>
Commit-Queue: Shawn Nematbakhsh <shawnn@chromium.org>

py/gooftool/gooftool.py

diff --git a/py/gooftool/gooftool.py b/py/gooftool/gooftool.py
index 5738a50..000be73 100755
--- a/py/gooftool/gooftool.py
+++ b/py/gooftool/gooftool.py
@@ -649,7 +649,7 @@
   elif method == 'ftps':
     report_upload.CurlUrlUpload(target_path, '--ftp-ssl-reqd ftp:%s' % param)
   elif method == 'cpfe':
-    report_upload.CpfeUpload(target_path, param)
+    report_upload.CpfeUpload(target_path, pipes.quote(param))
   else:
     raise Error('unknown report upload method %r', method)