factory: Deprecate cros.factory.common
Most functions in cros.factory.common are used by only very few modules and
should be moved to its own locations (for example, gooftool/, hwid/, or utils/).
BUG=chromium:557573
TEST=make test
Change-Id: I86da7764c1ae3205554a1521d02769ee3c2f2cf9
Reviewed-on: https://chromium-review.googlesource.com/313104
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>
diff --git a/py/gooftool/gooftool.py b/py/gooftool/gooftool.py
index 7e76b7a..cf0fb32 100755
--- a/py/gooftool/gooftool.py
+++ b/py/gooftool/gooftool.py
@@ -28,10 +28,10 @@
import factory_common # pylint: disable=W0611
-from cros.factory.common import SetupLogging, Shell
from cros.factory.gooftool import Gooftool
from cros.factory.gooftool import crosfw
from cros.factory.gooftool import report_upload
+from cros.factory.gooftool.common import Shell
from cros.factory.gooftool.probe import Probe, PROBEABLE_COMPONENT_CLASSES
from cros.factory.gooftool.probe import ReadRoVpd, ReadRwVpd
from cros.factory.gooftool.probe import CalculateFirmwareHashes
@@ -47,6 +47,7 @@
from cros.factory.test.factory import FACTORY_LOG_PATH, DEVICE_STATEFUL_PATH
from cros.factory.test.privacy import FilterDict
from cros.factory.utils import file_utils
+from cros.factory.utils.debug_utils import SetupLogging
from cros.factory.utils.process_utils import Spawn
from cros.factory.utils.type_utils import Error