commit 09312c5b34784de67c85860ebb2e3de8332f6aa6
author Yilin Yang <kerker@google.com> Wed Dec 04 13:50:35 2019 +0800
committer Commit Bot <commit-bot@chromium.org> Tue Mar 03 10:08:50 2020 +0000
tree 32901113d86029b8bb85ba48cc6e662c0a699a37
parent fa0f4e30ade93f499babe79c535c812b06a91003

factory: Specify 'w' mode for `tempfile.NamedTemporaryFile` when writing `str`

`tempfile.NamedTemporaryFile` will open in 'w+b' mode by default, it
means that we need to write exact `bytes` string to it in python3. So we
need to specify 'w' or 'w+' mode when we want to write `str` string.

BUG=chromium:999876
TEST=None

Change-Id: I9026a25f76636090d2a3d8c70ae836f196bdc561
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/factory/+/1991218
Reviewed-by: Cheng-Han Yang <chenghan@chromium.org>
Commit-Queue: Yilin Yang (kerker) <kerker@chromium.org>
Tested-by: Yilin Yang (kerker) <kerker@chromium.org>

py/toolkit/installer.py

diff --git a/py/toolkit/installer.py b/py/toolkit/installer.py
index 02769cd..870d9fa 100755
--- a/py/toolkit/installer.py
+++ b/py/toolkit/installer.py
@@ -348,7 +348,7 @@
     modified_msg = ''
   else:
     modified_msg = ' (modified %d times)' % modified_times
-  with tempfile.NamedTemporaryFile() as help_header:
+  with tempfile.NamedTemporaryFile('w') as help_header:
     help_header.write(initial_version + '\n' +
                       HELP_HEADER + HELP_HEADER_MAKESELF)
     help_header.flush()