commit fc71544203a9cfb8eca0dd11417dbec514812be0
author Chris Sosa <sosa@chromium.org> Wed Apr 09 20:45:23 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Fri Apr 11 20:01:32 2014 +0000
tree a2f2b26d3ee75ae1b1062947e920a68129564369
parent 4b95160d5f4ad1c0b7fa1345de3ce64d548c6796

Devserver: fix pylint errors in common_util.py.

BUG=chromium:344939
TEST=Unittests + pylint.

Change-Id: Ic798e58f258019aea563e30e39012db97a4728b4
Reviewed-on: https://chromium-review.googlesource.com/193992
Reviewed-by: Chris Sosa <sosa@chromium.org>
Commit-Queue: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>

autoupdate.py

diff --git a/autoupdate.py b/autoupdate.py
index ba4ba8f..58c83fa 100644
--- a/autoupdate.py
+++ b/autoupdate.py
@@ -678,9 +678,9 @@
           400, 'hardware_class is required in Omaha Request')
 
     track = app.getAttribute('track')
-    if not track or not track.endswith('-channel'):
+    if not (track and track.endswith('-channel')):
       raise common_util.DevServerHTTPError(
-          400, 'Omaha requests need an update channel')
+          400, 'Omaha requests need a valid update channel')
 
   def _GetStaticUrl(self):
     """Returns the static url base that should prefix all payload responses."""