Make sure chromite is properly imported at devserver startup.
At startup, before importing any modules from chromite, it's
necessary to import the 'chromite' package proper, in order to force
chromite/__init__.py to run. Because Python.
This adjusts the import order in devserver.py to honor the
requirement, and adds a "here be dragons" comment for the unwary.
BUG=chromium:757003
TEST=start the devserver, see it still work
Change-Id: I5f1d00c76a71fb985db4e1b11a65ed6461b1d149
Reviewed-on: https://chromium-review.googlesource.com/621670
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
diff --git a/devserver.py b/devserver.py
index 73cd6f6..ced16b5 100755
--- a/devserver.py
+++ b/devserver.py
@@ -60,6 +60,11 @@
from cherrypy import _cplogging as cplogging
from cherrypy.process import plugins
+# This must happen before any local modules get a chance to import
+# anything from chromite. Otherwise, really bad things will happen, and
+# you will _not_ understand why.
+import setup_chromite # pylint: disable=unused-import
+
import autoupdate
import artifact_info
import build_artifact
@@ -107,8 +112,6 @@
_Log('cros_update_progress cannot be imported: %r', e)
cros_update_progress = None
-# only import setup_chromite before chromite import.
-import setup_chromite # pylint: disable=unused-import
try:
from chromite.lib.paygen import gspaths
except ImportError as e: