commit bcb571e6ebadcf6f5a22905d7144f4af0e9f901c
author Frank Farzan <frankf@chromium.org> Tue Jan 03 11:48:17 2012 -0800
committer Gerrit <chrome-bot@google.com> Tue Jan 03 17:20:44 2012 -0800
tree b750a6041253777eec1640d35b2df2ce140ea0d2
parent 32ee2018cc90e668c421b06a395ee4eb0cb0496c

Refactor download API in the dev server.

Add comments and take named params.

BUG=chromium-os:24604
TEST=Ran dev server, verify download API works.

Change-Id: Ie7462e134dffe87f6e171e867ae62a752589a449
Reviewed-on: https://gerrit.chromium.org/gerrit/13593
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Ready: Frank Farzan <frankf@chromium.org>
Tested-by: Frank Farzan <frankf@chromium.org>

devserver.py

diff --git a/devserver.py b/devserver.py
index 2abd0a6..0f41553 100755
--- a/devserver.py
+++ b/devserver.py
@@ -160,13 +160,20 @@
     return self._builder.Build(board, pkg, kwargs)
 
   @cherrypy.expose
-  def download(self, *args):
-    """Downloads and archives full/delta payloads from Google Storage."""
+  def download(self, **kwargs):
+    """Downloads and archives full/delta payloads from Google Storage.
+
+    Args:
+      archive_url: Google Storage URL for the build.
+
+    Example URL:
+      'http://myhost/download?archive_url=gs://chromeos-image-archive/'
+      'x86-generic/R17-1208.0.0-a1-b338'
+    """
     import downloader
-    archive_url = '/'.join(args)
     if self._downloader is None:
       self._downloader = downloader.Downloader(updater.static_dir)
-    return self._downloader.Download(archive_url)
+    return self._downloader.Download(kwargs['archive_url'])
 
   @cherrypy.expose
   def controlfile(self, board, build, *args):