commit a06d2d2e00927b5d5cb141a3e2e7129d3c4876df
author Prashanth B <beeps@google.com> Fri Mar 07 15:35:19 2014 -0800
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Fri Mar 14 01:23:30 2014 +0000
tree 434b2f7455754b33b03b3f8f96b7f44e5d521413
parent 698ed5504b95f43193e718044aca450165cd839a

Add a devserver call that can list staged contents of a build.

This will help with knowing why an update failed.

TEST=Executed the call on a local devserver. Added a unittest.
BUG=chromium:348097, chromium:349044, chromium:349047

Change-Id: I9c1a1a0ba9212852ad243eec728a010b5ed0b0fc
Reviewed-on: https://chromium-review.googlesource.com/189672
Tested-by: Prashanth B <beeps@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Commit-Queue: Prashanth B <beeps@chromium.org>

devserver_integration_test.py

diff --git a/devserver_integration_test.py b/devserver_integration_test.py
index 755f2ce..49eea74 100755
--- a/devserver_integration_test.py
+++ b/devserver_integration_test.py
@@ -58,6 +58,7 @@
 CHECK_HEALTH = 'check_health'
 CONTROL_FILES = 'controlfiles'
 XBUDDY = 'xbuddy'
+LIST_IMAGE_DIR = 'list_image_dir'
 
 # API rpcs and constants.
 API_HOST_INFO = 'api/hostinfo'
@@ -512,6 +513,29 @@
                       self._MakeRPC,
                       '/'.join([XBUDDY, xbuddy_bad_path]))
 
+  def testListImageDir(self):
+    """Verifies that we can list the contents of the image directory."""
+    build_id = 'x86-mario-release/R32-4810.0.0'
+    archive_url = 'gs://chromeos-image-archive/%s' % build_id
+    build_dir = os.path.join(self.test_data_path, build_id)
+    shutil.rmtree(build_dir, ignore_errors=True)
+
+    logging.info('checking for %s on an unstaged build.', LIST_IMAGE_DIR)
+    response = self._MakeRPC(LIST_IMAGE_DIR, archive_url=archive_url)
+    self.assertTrue(archive_url in response and 'not been staged' in response)
+
+    logging.info('Checking for %s on a staged build.', LIST_IMAGE_DIR)
+    fake_file_name = 'fake_file'
+    try:
+      os.makedirs(build_dir)
+      open(os.path.join(build_dir, fake_file_name), 'w').close()
+    except OSError:
+      logging.error('Could not create files to imitate staged content. '
+                    'Build dir %s, file %s', build_dir, fake_file_name)
+      raise
+    response = self._MakeRPC(LIST_IMAGE_DIR, archive_url=archive_url)
+    self.assertTrue(fake_file_name in response)
+    shutil.rmtree(build_dir, ignore_errors=True)
 
 if __name__ == '__main__':
   logging_format = '%(levelname)-8s: %(message)s'