commit 86d16aa12f7e43a0d1b229e21e7349b99a5b5813
author Simon Glass <sjg@chromium.org> Fri Mar 09 15:29:05 2012 -0800
committer Gerrit <chrome-bot@google.com> Fri Mar 09 22:29:51 2012 -0800
tree dc8ec5a58e0d649074a24e7620a4c7f1f3095733
parent b4342afe7316ff8988a751639d0b04fdeca10d79

cros_bundle_firmware: Add a 'sudo' option to tools.Run()

Support this directly rather than requiring the caller to run the 'sudo'
tool with the real tool name as the first parameter.

We can then locate the sudo'd tool properly.

BUG=chromium-os:19724
TEST=emerge chromeos-bootimage

Change-Id: I7933968279519a7fde1f8a48fbde7cdaae277b8d
Reviewed-on: https://gerrit.chromium.org/gerrit/17765
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Commit-Ready: Simon Glass <sjg@chromium.org>

host/lib/write_firmware.py

diff --git a/host/lib/write_firmware.py b/host/lib/write_firmware.py
index 41daf78..fce66e8 100644
--- a/host/lib/write_firmware.py
+++ b/host/lib/write_firmware.py
@@ -228,7 +228,6 @@
 
     self._out.Progress('Uploading flasher image')
     args = [
-      'nvflash',
       '--bct', bct,
       '--setbct',
       '--bl',  flasher,
@@ -240,9 +239,8 @@
     last_err = None
     for tries in range(10):
       try:
-        # TODO(sjg): Make sudo an argument to Run()
         # TODO(sjg): Use Chromite library so we can monitor output
-        self._tools.Run('sudo', args)
+        self._tools.Run('nvflash', args, sudo=True)
         self._out.Notice('Flasher downloaded - please see serial output '
             'for progress.')
         return True