commit 0b8c3f38a5f41827d7fd5113d25e310b38ac943f
author Gilad Arnold <garnold@chromium.org> Wed Sep 19 14:35:44 2012 -0700
committer Gerrit <chrome-bot@google.com> Wed Sep 19 18:51:58 2012 -0700
tree e4605553477595377ff7c131ece2abd3e80358eb
parent dd2abb0d513be8292f7385995b5d16e68d67c8f4

devserver: generalize lock dictionary; substitute multiprocessing for threading

* Migrate the lock dictionary functionality into a dedicated class, so
  it can be easily used with other sets of resources.

* Replace multiprocessing primitives (processes, locks) with threading
  equivalents. There's no apparent reason for using multiprocessing, and
  threading primitives are expected to be faster/lighter.

BUG=None
TEST=Passes unit tests

Change-Id: I7e3671a55d17f6bc60217b278ccc7b69c72c6c48
Reviewed-on: https://gerrit.chromium.org/gerrit/33641
Reviewed-by: Gilad Arnold <garnold@chromium.org>
Tested-by: Gilad Arnold <garnold@chromium.org>
Commit-Ready: Gilad Arnold <garnold@chromium.org>

downloader.py

diff --git a/downloader.py b/downloader.py
index 17dadba..710a425 100755
--- a/downloader.py
+++ b/downloader.py
@@ -4,11 +4,12 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import Queue
 import cherrypy
-import multiprocessing
 import os
 import shutil
 import tempfile
+import threading
 
 import devserver_util
 
@@ -32,7 +33,7 @@
     self._static_dir = static_dir
     self._build_dir = None
     self._staging_dir = None
-    self._status_queue = multiprocessing.Queue(maxsize=1)
+    self._status_queue = Queue.Queue(maxsize=1)
     self._lock_tag = None
 
   @staticmethod
@@ -158,7 +159,7 @@
 
   def _DownloadArtifactsSerially(self, artifacts):
     """Simple function to download all the given artifacts serially."""
-    cherrypy.log('Downloading background artifacts serially.', self._LOG_TAG)
+    cherrypy.log('Downloading artifacts serially.', self._LOG_TAG)
     try:
       for artifact in artifacts:
         artifact.Download()
@@ -178,9 +179,10 @@
 
   def _DownloadArtifactsInBackground(self, artifacts):
     """Downloads |artifacts| in the background and signals when complete."""
-    proc = multiprocessing.Process(target=self._DownloadArtifactsSerially,
-                                   args=(artifacts,))
-    proc.start()
+    cherrypy.log('Invoking background download of artifacts', self._LOG_TAG)
+    thread = threading.Thread(target=self._DownloadArtifactsSerially,
+                              args=(artifacts,))
+    thread.start()
 
   def GatherArtifactDownloads(self, main_staging_dir, archive_url, short_build,
                               build_dir):