commit 74bcb6436d17d1cab9bcf82af7601df2b7e78810
author Kuang-che Wu <kcwu@chromium.org> Thu Feb 20 18:45:53 2020 +0800
committer Kuang-che Wu <kcwu@chromium.org> Thu Feb 20 19:01:11 2020 +0800
tree d97d72e108a2f7263fc97cd0df365780c70bc41f
parent 313eec3277fa5715a42e75a1b0cfa4bbe17941f1

bisect-kit: fix resource warning

python3 raise warning ResourceWarning: unclosed file

BUG=None
TEST=unittest

Change-Id: I4f6f184f5696cf486000e8516881071c41e2acf2

bisect_kit/codechange.py

diff --git a/bisect_kit/codechange.py b/bisect_kit/codechange.py
index 900a5a0..b1b1347 100644
--- a/bisect_kit/codechange.py
+++ b/bisect_kit/codechange.py
@@ -1011,8 +1011,9 @@
           'cached revlist not found: %s' % cache_filename)
 
     result = []
-    for data in json.load(open(cache_filename)):
-      result.append(ActionGroup.unserialize(data))
+    with open(cache_filename) as f:
+      for data in json.load(f):
+        result.append(ActionGroup.unserialize(data))
 
     return result