commit 6fd9a7ffdf1e780481f9e3278f79cfd1680aa4c1
author Kuang-che Wu <kcwu@chromium.org> Tue Jan 12 08:07:51 2021 +0800
committer Commit Bot <commit-bot@chromium.org> Tue Jan 12 03:15:31 2021 +0000
tree 38c699ad99f73d01c99f19bcdcf4b0c5700fffc4
parent 55bedc6405aaf4ab34966b6c74a43fe58deabfd0

bisect-kit: revise git_util.is_ancestor_commit

Handle if commits don't exist.

BUG=None
TEST=unit test

Change-Id: I7d9bbbad1fa5a5661e736584c905a61850f1ba57
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/bisect-kit/+/2622687
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Auto-Submit: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Zheng-Jie Chang <zjchang@chromium.org>
Reviewed-by: Zheng-Jie Chang <zjchang@chromium.org>

bisect_kit/git_util.py

diff --git a/bisect_kit/git_util.py b/bisect_kit/git_util.py
index 3f8f4f5..588cd5a 100644
--- a/bisect_kit/git_util.py
+++ b/bisect_kit/git_util.py
@@ -346,13 +346,16 @@
     True only if `old` is the ancestor of `new`. One commit is not considered
     as ancestor of itself.
   """
-  return util.check_output(
-      'git',
-      'rev-list',
-      '--ancestry-path',
-      '-1',
-      '%s..%s' % (old, new),
-      cwd=git_repo) != ''
+  try:
+    return util.check_output(
+        'git',
+        'rev-list',
+        '--ancestry-path',
+        '-1',
+        '%s..%s' % (old, new),
+        cwd=git_repo) != ''
+  except subprocess.CalledProcessError:
+    return False
 
 
 def _parse_commit_object(s):