bisect-kit: gclient sync has deprecated "--ignore_locks" option
gclient sync started to use OS level lock and no longer need this option.
BUG=None
TEST=None
Change-Id: I265d7aea534260527cd5c97a2d273f35d11ddd70
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/bisect-kit/+/2513906
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Auto-Submit: Kuang-che Wu <kcwu@chromium.org>
Commit-Queue: Zheng-Jie Chang <zjchang@chromium.org>
Reviewed-by: Zheng-Jie Chang <zjchang@chromium.org>
diff --git a/bisect_kit/gclient_util.py b/bisect_kit/gclient_util.py
index 9cb14a3..da53b54 100644
--- a/bisect_kit/gclient_util.py
+++ b/bisect_kit/gclient_util.py
@@ -67,18 +67,13 @@
util.check_call(*cmd, cwd=gclient_dir)
-def sync(gclient_dir,
- with_branch_heads=False,
- with_tags=False,
- ignore_locks=False,
- jobs=8):
+def sync(gclient_dir, with_branch_heads=False, with_tags=False, jobs=8):
"""Simply wrapper of `gclient sync`.
Args:
gclient_dir: root directory of gclient project
with_branch_heads: whether to clone git `branch_heads` refspecs
with_tags: whether to clone git tags
- ignore_locks: bypass gclient's lock
jobs: how many workers running in parallel
"""
# Work around gclient issue crbug/943430
@@ -103,13 +98,6 @@
if with_tags:
cmd.append('--with_tags')
- # If 'gclient sync' is interrupted by ctrl-c or terminated with whatever
- # reasons, it will leave annoying lock files on disk and thus unfriendly to
- # bot tasks. In bisect-kit, we will use our own lock mechanism (in caller of
- # this function) and bypass gclient's.
- if ignore_locks:
- cmd.append('--ignore_locks')
-
try:
old_projects = load_gclient_entries(gclient_dir)
except IOError: