bisect-kit: fix pylint errors
Besides normal fixes, BisectorCommandLineInterface is renamed to
BisectorCommandLine. Although new version of pylint no longer complain
interface-not-implemented (instead, saying the disable option is
undefined), chromite and depot_tools still use the old one. Renaming is
easier to avoid the annoyingness.
BUG=chromium:776314
TEST=cros lint *.py bisect_kit/*.py
Change-Id: I4cf3f63ee950d913a6b3f5b6a7a7b59810066963
Reviewed-on: https://chromium-review.googlesource.com/987660
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
diff --git a/bisect_kit/cli_test.py b/bisect_kit/cli_test.py
index 8002581..d67cf49 100644
--- a/bisect_kit/cli_test.py
+++ b/bisect_kit/cli_test.py
@@ -122,9 +122,8 @@
@mock.patch('bisect_kit.common.config_logging', mock.Mock())
-# This is not an python "interface". pylint: disable=interface-not-implemented
-class TestBisectorCommandLineInterface(unittest.TestCase):
- """Test cli.BisectorCommandLineInterface class."""
+class TestBisectorCommandLine(unittest.TestCase):
+ """Test cli.BisectorCommandLine class."""
def setUp(self):
self.session_base = tempfile.mkdtemp()
@@ -137,7 +136,7 @@
self.patcher.stop()
def test_run_true(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=10', '--old=0', '--new=9')
bisector.main('config', 'switch', 'true')
bisector.main('config', 'eval', 'true')
@@ -145,7 +144,7 @@
bisector.main('run')
def test_run_false(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=10', '--old=0', '--new=9')
bisector.main('config', 'switch', 'true')
bisector.main('config', 'eval', 'false')
@@ -153,7 +152,7 @@
bisector.main('run')
def test_simple(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=20', '--old=3', '--new=15')
bisector.main('config', 'switch', 'true')
bisector.main('config', 'eval', 'sh', '-c', '[ "$BISECT_REV" -lt 7 ]')
@@ -161,7 +160,7 @@
self.assertEqual(bisector.strategy.get_best_guess(), 7)
def test_switch_fail(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=20', '--old=3', '--new=15')
bisector.main('config', 'switch', 'false')
bisector.main('config', 'eval', 'sh', '-c', '[ "$BISECT_REV" -lt 7 ]')
@@ -169,7 +168,7 @@
bisector.main('run')
def test_run_classic(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=200', '--old=0', '--new=99')
bisector.main('config', 'switch', 'true')
bisector.main('config', 'eval', 'false')
@@ -206,7 +205,7 @@
self.assertEqual(mock_stdout.getvalue(), 'done\n')
def test_run_noisy(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=100', '--old=0', '--new=99',
'--noisy=old=1/10,new=9/10')
bisector.main('config', 'switch', 'true')
@@ -233,7 +232,7 @@
def test_cmd_old_and_new(self):
"""Tests cmd_old and cmd_new"""
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=100', '--old=0', '--new=99')
bisector.main('config', 'switch', 'true')
bisector.main('config', 'eval', 'false')
@@ -253,7 +252,7 @@
def test_cmd_switch(self):
"""Test cmd_switch"""
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=100', '--old=0', '--new=99')
bisector.main('config', 'switch', 'true')
bisector.main('config', 'eval', 'false')
@@ -271,14 +270,14 @@
self.assertEqual(switched, ['99', '3', '5', '4'])
def test_cmd_view(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=100', '--old=10', '--new=90')
with mock.patch.object(DummyDomain, 'view') as mock_view:
bisector.main('view')
mock_view.assert_called_with('10', '90')
def test_cmd_config_confidence(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=100', '--old=10', '--new=90',
'--confidence=0.75')
@@ -292,7 +291,7 @@
self.assertEqual(bisector.states.config['confidence'], 0.875)
def test_cmd_config_noisy(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
bisector.main('init', '--num=100', '--old=10', '--new=90',
'--noisy=new=9/10')
@@ -304,7 +303,7 @@
self.assertEqual(bisector.states.config['noisy'], 'old=1/10,new=8/9')
def test_current_status(self):
- bisector = cli.BisectorCommandLineInterface(DummyDomain)
+ bisector = cli.BisectorCommandLine(DummyDomain)
result = bisector.current_status()
self.assertEqual(result.get('inited'), False)