commit 603cdadc366b718e1ab669d1a502588ae5eb08c4
author Kuang-che Wu <kcwu@chromium.org> Fri Jan 18 21:32:55 2019 +0800
committer chrome-bot <chrome-bot@chromium.org> Sun Jan 20 19:58:13 2019 -0800
tree 6425bef8332e2fae84bd68caa0a1d8ea3ab9e466
parent 86fbde51c17904d89ed4b0210863cd786343b113

bisect-kit: refactor cli.argtype_multiplexer

extract regex matching as separate type, argtype_re

BUG=None
TEST=unittest

Change-Id: Ic5783ededa94f52274360a04233794ac41edd593
Reviewed-on: https://chromium-review.googlesource.com/1421577
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

bisect_kit/cli_test.py

diff --git a/bisect_kit/cli_test.py b/bisect_kit/cli_test.py
index 54d15ce..1f630a4 100644
--- a/bisect_kit/cli_test.py
+++ b/bisect_kit/cli_test.py
@@ -34,8 +34,17 @@
     with self.assertRaises(cli.ArgTypeError):
       cli.argtype_notempty('')
 
+  def test_argtype_re(self):
+    argtype = cli.argtype_re(r'^r\d+$', 'r123')
+    self.assertEqual(argtype('r123'), 'r123')
+
+    with self.assertRaises(cli.ArgTypeError):
+      argtype('hello')
+
   def test_argtype_multiplexer(self):
-    argtype = cli.argtype_multiplexer(cli.argtype_int, 'foobar', r'^r\d+$')
+    argtype = cli.argtype_multiplexer(cli.argtype_int,
+                                      cli.argtype_re('foobar', 'foobar'),
+                                      cli.argtype_re(r'^r\d+$', 'r123'))
     self.assertEqual(argtype('123456'), '123456')
     self.assertEqual(argtype('foobar'), 'foobar')
     self.assertEqual(argtype('r123'), 'r123')