Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 1 | # Copyright (c) 2013 The Chromium OS Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """Upload all debug symbols required for crash reporting purposes. |
| 6 | |
| 7 | This script need only be used to upload release builds symbols or to debug |
| 8 | crashes on non-release builds (in which case try to only upload the symbols |
Mike Frysinger | 02e1e07 | 2013-11-10 22:11:34 -0500 | [diff] [blame] | 9 | for those executables involved). |
| 10 | """ |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 11 | |
Mike Frysinger | a4fa1e8 | 2014-01-15 01:45:56 -0500 | [diff] [blame] | 12 | from __future__ import print_function |
| 13 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 14 | import ctypes |
Mike Frysinger | 8ec8c50 | 2014-02-10 00:19:13 -0500 | [diff] [blame] | 15 | import datetime |
Mike Frysinger | dad2a03 | 2014-05-11 23:05:11 -0400 | [diff] [blame] | 16 | import errno |
Mike Frysinger | 02e9240 | 2013-11-22 16:22:02 -0500 | [diff] [blame] | 17 | import functools |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 18 | import hashlib |
Mike Frysinger | a4fa1e8 | 2014-01-15 01:45:56 -0500 | [diff] [blame] | 19 | import httplib |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 20 | import multiprocessing |
| 21 | import os |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 22 | import poster |
Mike Frysinger | 66e51e9 | 2014-05-03 16:52:00 -0400 | [diff] [blame] | 23 | try: |
| 24 | import Queue |
| 25 | except ImportError: |
| 26 | # Python-3 renamed to "queue". We still use Queue to avoid collisions |
| 27 | # with naming variables as "queue". Maybe we'll transition at some point. |
| 28 | # pylint: disable=F0401 |
| 29 | import queue as Queue |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 30 | import random |
Mike Frysinger | 66e51e9 | 2014-05-03 16:52:00 -0400 | [diff] [blame] | 31 | import signal |
Mike Frysinger | fd35565 | 2014-01-23 02:57:48 -0500 | [diff] [blame] | 32 | import socket |
Mike Frysinger | c5597f2 | 2014-11-27 15:39:15 -0500 | [diff] [blame] | 33 | import sys |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 34 | import textwrap |
| 35 | import tempfile |
| 36 | import time |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 37 | import urllib2 |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 38 | import urlparse |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 39 | |
Don Garrett | 88b8d78 | 2014-05-13 17:30:55 -0700 | [diff] [blame] | 40 | from chromite.cbuildbot import constants |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 41 | from chromite.lib import cache |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 42 | from chromite.lib import commandline |
| 43 | from chromite.lib import cros_build_lib |
Ralph Nathan | 5a582ff | 2015-03-20 18:18:30 -0700 | [diff] [blame] | 44 | from chromite.lib import cros_logging as logging |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 45 | from chromite.lib import gs |
| 46 | from chromite.lib import osutils |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 47 | from chromite.lib import parallel |
David James | c93e6a4d | 2014-01-13 11:37:36 -0800 | [diff] [blame] | 48 | from chromite.lib import retry_util |
Mike Frysinger | 66e51e9 | 2014-05-03 16:52:00 -0400 | [diff] [blame] | 49 | from chromite.lib import signals |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 50 | from chromite.lib import timeout_util |
Mike Frysinger | 69cb41d | 2013-08-11 20:08:19 -0400 | [diff] [blame] | 51 | from chromite.scripts import cros_generate_breakpad_symbols |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 52 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 53 | # Needs to be after chromite imports. |
Mike Frysinger | c5597f2 | 2014-11-27 15:39:15 -0500 | [diff] [blame] | 54 | # We don't want to import the general keyring module as that will implicitly |
| 55 | # try to import & connect to a dbus server. That's a waste of time. |
| 56 | sys.modules['keyring'] = None |
| 57 | import isolateserver |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 58 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 59 | |
| 60 | # URLs used for uploading symbols. |
| 61 | OFFICIAL_UPLOAD_URL = 'http://clients2.google.com/cr/symbol' |
| 62 | STAGING_UPLOAD_URL = 'http://clients2.google.com/cr/staging_symbol' |
| 63 | |
| 64 | |
| 65 | # The crash server rejects files that are this big. |
| 66 | CRASH_SERVER_FILE_LIMIT = 350 * 1024 * 1024 |
| 67 | # Give ourselves a little breathing room from what the server expects. |
| 68 | DEFAULT_FILE_LIMIT = CRASH_SERVER_FILE_LIMIT - (10 * 1024 * 1024) |
| 69 | |
| 70 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 71 | # The batch limit when talking to the dedup server. We avoid sending one at a |
| 72 | # time as the round trip overhead will dominate. Conversely, we avoid sending |
| 73 | # all at once so we can start uploading symbols asap -- the symbol server is a |
| 74 | # bit slow and will take longer than anything else. |
| 75 | # TODO: A better algorithm would be adaptive. If we have more than one symbol |
| 76 | # in the upload queue waiting, we could send more symbols to the dedupe server |
| 77 | # at a time. |
| 78 | DEDUPE_LIMIT = 100 |
| 79 | |
| 80 | # How long to wait for the server to respond with the results. Note that the |
| 81 | # larger the limit above, the larger this will need to be. So we give it ~1 |
| 82 | # second per item max. |
| 83 | DEDUPE_TIMEOUT = DEDUPE_LIMIT |
| 84 | |
Mike Frysinger | 4dd462e | 2014-04-30 16:21:51 -0400 | [diff] [blame] | 85 | # How long to wait for the notification to finish (in minutes). If it takes |
| 86 | # longer than this, we'll stop notifiying, but that's not a big deal as we |
| 87 | # will be able to recover in later runs. |
| 88 | DEDUPE_NOTIFY_TIMEOUT = 20 |
| 89 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 90 | # The unique namespace in the dedupe server that only we use. Helps avoid |
| 91 | # collisions with all the hashed values and unrelated content. |
| 92 | OFFICIAL_DEDUPE_NAMESPACE = 'chromium-os-upload-symbols' |
| 93 | STAGING_DEDUPE_NAMESPACE = '%s-staging' % OFFICIAL_DEDUPE_NAMESPACE |
| 94 | |
| 95 | |
Mike Frysinger | 7104666 | 2014-09-12 18:15:15 -0700 | [diff] [blame] | 96 | # The minimum average rate (in bytes per second) that we expect to maintain |
| 97 | # when uploading symbols. This has to allow for symbols that are up to |
| 98 | # CRASH_SERVER_FILE_LIMIT in size. |
| 99 | UPLOAD_MIN_RATE = CRASH_SERVER_FILE_LIMIT / (30 * 60) |
| 100 | |
| 101 | # The lowest timeout (in seconds) we'll allow. If the server is overloaded, |
| 102 | # then there might be a delay in setting up the connection, not just with the |
| 103 | # transfer. So even a small file might need a larger value. |
| 104 | UPLOAD_MIN_TIMEOUT = 2 * 60 |
Mike Frysinger | cd78a08 | 2013-06-26 17:13:04 -0400 | [diff] [blame] | 105 | |
| 106 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 107 | # Sleep for 200ms in between uploads to avoid DoS'ing symbol server. |
| 108 | DEFAULT_SLEEP_DELAY = 0.2 |
| 109 | |
| 110 | |
| 111 | # Number of seconds to wait before retrying an upload. The delay will double |
| 112 | # for each subsequent retry of the same symbol file. |
| 113 | INITIAL_RETRY_DELAY = 1 |
| 114 | |
| 115 | # Allow up to 7 attempts to upload a symbol file (total delay may be |
| 116 | # 1+2+4+8+16+32=63 seconds). |
| 117 | MAX_RETRIES = 6 |
| 118 | |
Mike Frysinger | eb753bf | 2013-11-22 16:05:35 -0500 | [diff] [blame] | 119 | # Number of total errors, before uploads are no longer attempted. |
| 120 | # This is used to avoid lots of errors causing unreasonable delays. |
| 121 | # See the related, but independent, error values below. |
| 122 | MAX_TOTAL_ERRORS_FOR_RETRY = 30 |
| 123 | |
| 124 | # A watermark of transient errors which we allow recovery from. If we hit |
| 125 | # errors infrequently, overall we're probably doing fine. For example, if |
| 126 | # we have one failure every 100 passes, then we probably don't want to fail |
| 127 | # right away. But if we hit a string of failures in a row, we want to abort. |
| 128 | # |
| 129 | # The watermark starts at 0 (and can never go below that). When this error |
| 130 | # level is exceeded, we stop uploading. When a failure happens, we add the |
| 131 | # fail adjustment, and when an upload succeeds, we add the pass adjustment. |
| 132 | # We want to penalize failures more so that we ramp up when there is a string |
| 133 | # of them, but then slowly back off as things start working. |
| 134 | # |
| 135 | # A quick example: |
| 136 | # 0.0: Starting point. |
| 137 | # 0.0: Upload works, so add -0.5, and then clamp to 0. |
| 138 | # 1.0: Upload fails, so add 1.0. |
| 139 | # 2.0: Upload fails, so add 1.0. |
| 140 | # 1.5: Upload works, so add -0.5. |
| 141 | # 1.0: Upload works, so add -0.5. |
| 142 | ERROR_WATERMARK = 3.0 |
| 143 | ERROR_ADJUST_FAIL = 1.0 |
| 144 | ERROR_ADJUST_PASS = -0.5 |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 145 | |
| 146 | |
Mike Frysinger | 0a2fd92 | 2014-09-12 20:23:42 -0700 | [diff] [blame] | 147 | def GetUploadTimeout(path): |
| 148 | """How long to wait for a specific file to upload to the crash server. |
| 149 | |
| 150 | This is a function largely to make unittesting easier. |
| 151 | |
| 152 | Args: |
| 153 | path: The path to the file to calculate the timeout for |
| 154 | |
| 155 | Returns: |
| 156 | Timeout length (in seconds) |
| 157 | """ |
| 158 | # Scale the timeout based on the filesize. |
| 159 | return max(os.path.getsize(path) / UPLOAD_MIN_RATE, UPLOAD_MIN_TIMEOUT) |
| 160 | |
| 161 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 162 | def SymUpload(upload_url, sym_item): |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 163 | """Upload a symbol file to a HTTP server |
| 164 | |
| 165 | The upload is a multipart/form-data POST with the following parameters: |
| 166 | code_file: the basename of the module, e.g. "app" |
| 167 | code_identifier: the module file's identifier |
| 168 | debug_file: the basename of the debugging file, e.g. "app" |
| 169 | debug_identifier: the debug file's identifier, usually consisting of |
| 170 | the guid and age embedded in the pdb, e.g. |
| 171 | "11111111BBBB3333DDDD555555555555F" |
| 172 | version: the file version of the module, e.g. "1.2.3.4" |
| 173 | product: HTTP-friendly product name |
| 174 | os: the operating system that the module was built for |
| 175 | cpu: the CPU that the module was built for |
| 176 | symbol_file: the contents of the breakpad-format symbol file |
| 177 | |
| 178 | Args: |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 179 | upload_url: The crash URL to POST the |sym_file| to |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 180 | sym_item: A SymbolItem containing the path to the breakpad symbol to upload |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 181 | """ |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 182 | sym_header = sym_item.sym_header |
| 183 | sym_file = sym_item.sym_file |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 184 | |
| 185 | fields = ( |
| 186 | ('code_file', sym_header.name), |
| 187 | ('debug_file', sym_header.name), |
| 188 | ('debug_identifier', sym_header.id.replace('-', '')), |
Mike Frysinger | b8a966b | 2014-03-19 17:36:18 -0400 | [diff] [blame] | 189 | # The product/version fields are used by the server only for statistic |
| 190 | # purposes. They do not impact symbolization, so they're safe to set |
| 191 | # to any value all the time. |
| 192 | # In this case, we use it to help see the load our build system is |
| 193 | # placing on the server. |
| 194 | # Not sure what to set for the version. Maybe the git sha1 of this file. |
| 195 | # Note: the server restricts this to 30 chars. |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 196 | #('version', None), |
Mike Frysinger | b8a966b | 2014-03-19 17:36:18 -0400 | [diff] [blame] | 197 | ('product', 'ChromeOS'), |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 198 | ('os', sym_header.os), |
| 199 | ('cpu', sym_header.cpu), |
| 200 | poster.encode.MultipartParam.from_file('symbol_file', sym_file), |
| 201 | ) |
| 202 | |
| 203 | data, headers = poster.encode.multipart_encode(fields) |
| 204 | request = urllib2.Request(upload_url, data, headers) |
| 205 | request.add_header('User-agent', 'chromite.upload_symbols') |
Mike Frysinger | 0a2fd92 | 2014-09-12 20:23:42 -0700 | [diff] [blame] | 206 | urllib2.urlopen(request, timeout=GetUploadTimeout(sym_file)) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 207 | |
| 208 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 209 | def TestingSymUpload(upload_url, sym_item): |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 210 | """A stub version of SymUpload for --testing usage""" |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 211 | cmd = ['sym_upload', sym_item.sym_file, upload_url] |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 212 | # Randomly fail 80% of the time (the retry logic makes this 80%/3 per file). |
| 213 | returncode = random.randint(1, 100) <= 80 |
Ralph Nathan | 5a582ff | 2015-03-20 18:18:30 -0700 | [diff] [blame] | 214 | logging.debug('would run (and return %i): %s', returncode, |
| 215 | cros_build_lib.CmdToStr(cmd)) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 216 | if returncode: |
| 217 | output = 'Failed to send the symbol file.' |
| 218 | else: |
| 219 | output = 'Successfully sent the symbol file.' |
| 220 | result = cros_build_lib.CommandResult(cmd=cmd, error=None, output=output, |
| 221 | returncode=returncode) |
| 222 | if returncode: |
Mike Frysinger | a4fa1e8 | 2014-01-15 01:45:56 -0500 | [diff] [blame] | 223 | exceptions = ( |
Mike Frysinger | fd35565 | 2014-01-23 02:57:48 -0500 | [diff] [blame] | 224 | socket.error('[socket.error] forced test fail'), |
Mike Frysinger | a4fa1e8 | 2014-01-15 01:45:56 -0500 | [diff] [blame] | 225 | httplib.BadStatusLine('[BadStatusLine] forced test fail'), |
| 226 | urllib2.HTTPError(upload_url, 400, '[HTTPError] forced test fail', |
| 227 | {}, None), |
| 228 | urllib2.URLError('[URLError] forced test fail'), |
| 229 | ) |
| 230 | raise random.choice(exceptions) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 231 | else: |
| 232 | return result |
| 233 | |
| 234 | |
Mike Frysinger | eb753bf | 2013-11-22 16:05:35 -0500 | [diff] [blame] | 235 | def ErrorLimitHit(num_errors, watermark_errors): |
| 236 | """See if our error limit has been hit |
| 237 | |
| 238 | Args: |
| 239 | num_errors: A multiprocessing.Value of the raw number of failures. |
| 240 | watermark_errors: A multiprocessing.Value of the current rate of failures. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 241 | |
Mike Frysinger | eb753bf | 2013-11-22 16:05:35 -0500 | [diff] [blame] | 242 | Returns: |
| 243 | True if our error limits have been exceeded. |
| 244 | """ |
| 245 | return ((num_errors is not None and |
| 246 | num_errors.value > MAX_TOTAL_ERRORS_FOR_RETRY) or |
| 247 | (watermark_errors is not None and |
| 248 | watermark_errors.value > ERROR_WATERMARK)) |
| 249 | |
| 250 | |
| 251 | def _UpdateCounter(counter, adj): |
| 252 | """Update |counter| by |adj| |
| 253 | |
| 254 | Handle atomic updates of |counter|. Also make sure it does not |
| 255 | fall below 0. |
| 256 | |
| 257 | Args: |
| 258 | counter: A multiprocessing.Value to update |
| 259 | adj: The value to add to |counter| |
| 260 | """ |
| 261 | def _Update(): |
| 262 | clamp = 0 if type(adj) is int else 0.0 |
| 263 | counter.value = max(clamp, counter.value + adj) |
| 264 | |
| 265 | if hasattr(counter, 'get_lock'): |
| 266 | with counter.get_lock(): |
| 267 | _Update() |
| 268 | elif counter is not None: |
| 269 | _Update() |
| 270 | |
| 271 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 272 | def UploadSymbol(upload_url, sym_item, file_limit=DEFAULT_FILE_LIMIT, |
Mike Frysinger | 02e9240 | 2013-11-22 16:22:02 -0500 | [diff] [blame] | 273 | sleep=0, num_errors=None, watermark_errors=None, |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 274 | failed_queue=None, passed_queue=None): |
| 275 | """Upload |sym_item| to |upload_url| |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 276 | |
| 277 | Args: |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 278 | upload_url: The crash server to upload things to |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 279 | sym_item: A SymbolItem containing the path to the breakpad symbol to upload |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 280 | file_limit: The max file size of a symbol file before we try to strip it |
| 281 | sleep: Number of seconds to sleep before running |
Mike Frysinger | 69cb41d | 2013-08-11 20:08:19 -0400 | [diff] [blame] | 282 | num_errors: An object to update with the error count (needs a .value member) |
Mike Frysinger | eb753bf | 2013-11-22 16:05:35 -0500 | [diff] [blame] | 283 | watermark_errors: An object to track current error behavior (needs a .value) |
Mike Frysinger | 02e9240 | 2013-11-22 16:22:02 -0500 | [diff] [blame] | 284 | failed_queue: When a symbol fails, add it to this queue |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 285 | passed_queue: When a symbol passes, add it to this queue |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 286 | |
Mike Frysinger | 69cb41d | 2013-08-11 20:08:19 -0400 | [diff] [blame] | 287 | Returns: |
| 288 | The number of errors that were encountered. |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 289 | """ |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 290 | sym_file = sym_item.sym_file |
| 291 | upload_item = sym_item |
| 292 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 293 | if num_errors is None: |
| 294 | num_errors = ctypes.c_int() |
Mike Frysinger | eb753bf | 2013-11-22 16:05:35 -0500 | [diff] [blame] | 295 | if ErrorLimitHit(num_errors, watermark_errors): |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 296 | # Abandon ship! It's on fire! NOoooooooooooOOOoooooo. |
Mike Frysinger | 7f9be14 | 2014-01-15 02:16:42 -0500 | [diff] [blame] | 297 | if failed_queue: |
| 298 | failed_queue.put(sym_file) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 299 | return 0 |
| 300 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 301 | if sleep: |
| 302 | # Keeps us from DoS-ing the symbol server. |
| 303 | time.sleep(sleep) |
| 304 | |
Ralph Nathan | 5a582ff | 2015-03-20 18:18:30 -0700 | [diff] [blame] | 305 | logging.debug('uploading %s' % sym_file) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 306 | |
| 307 | # Ideally there'd be a tempfile.SpooledNamedTemporaryFile that we could use. |
| 308 | with tempfile.NamedTemporaryFile(prefix='upload_symbols', |
| 309 | bufsize=0) as temp_sym_file: |
| 310 | if file_limit: |
| 311 | # If the symbols size is too big, strip out the call frame info. The CFI |
| 312 | # is unnecessary for 32bit x86 targets where the frame pointer is used (as |
| 313 | # all of ours have) and it accounts for over half the size of the symbols |
| 314 | # uploaded. |
| 315 | file_size = os.path.getsize(sym_file) |
| 316 | if file_size > file_limit: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 317 | logging.warning('stripping CFI from %s due to size %s > %s', sym_file, |
| 318 | file_size, file_limit) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 319 | temp_sym_file.writelines([x for x in open(sym_file, 'rb').readlines() |
| 320 | if not x.startswith('STACK CFI')]) |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 321 | |
| 322 | upload_item = FakeItem(sym_file=temp_sym_file.name, |
Mike Frysinger | d6e2df0 | 2014-11-26 02:55:04 -0500 | [diff] [blame] | 323 | sym_header=sym_item.sym_header) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 324 | |
| 325 | # Hopefully the crash server will let it through. But it probably won't. |
| 326 | # Not sure what the best answer is in this case. |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 327 | file_size = os.path.getsize(upload_item.sym_file) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 328 | if file_size > CRASH_SERVER_FILE_LIMIT: |
| 329 | cros_build_lib.PrintBuildbotStepWarnings() |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 330 | logging.warning('upload file %s is awfully large, risking rejection by ' |
| 331 | 'the symbol server (%s > %s)', sym_file, file_size, |
| 332 | CRASH_SERVER_FILE_LIMIT) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 333 | |
| 334 | # Upload the symbol file. |
Mike Frysinger | eb753bf | 2013-11-22 16:05:35 -0500 | [diff] [blame] | 335 | success = False |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 336 | try: |
Mike Frysinger | 9adcfd2 | 2013-10-24 12:01:40 -0400 | [diff] [blame] | 337 | cros_build_lib.TimedCommand( |
David James | c93e6a4d | 2014-01-13 11:37:36 -0800 | [diff] [blame] | 338 | retry_util.RetryException, |
Mike Frysinger | 9adcfd2 | 2013-10-24 12:01:40 -0400 | [diff] [blame] | 339 | (urllib2.HTTPError, urllib2.URLError), MAX_RETRIES, SymUpload, |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 340 | upload_url, upload_item, sleep=INITIAL_RETRY_DELAY, |
Mike Frysinger | f50187c | 2014-11-27 22:01:29 -0500 | [diff] [blame] | 341 | timed_log_msg=('upload of %10i bytes took %%(delta)s: %s' % |
Mike Frysinger | d6e2df0 | 2014-11-26 02:55:04 -0500 | [diff] [blame] | 342 | (file_size, os.path.basename(sym_file)))) |
Mike Frysinger | eb753bf | 2013-11-22 16:05:35 -0500 | [diff] [blame] | 343 | success = True |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 344 | |
| 345 | if passed_queue: |
| 346 | passed_queue.put(sym_item) |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 347 | except urllib2.HTTPError as e: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 348 | logging.warning('could not upload: %s: HTTP %s: %s', |
| 349 | os.path.basename(sym_file), e.code, e.reason) |
Mike Frysinger | fd35565 | 2014-01-23 02:57:48 -0500 | [diff] [blame] | 350 | except (urllib2.URLError, httplib.HTTPException, socket.error) as e: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 351 | logging.warning('could not upload: %s: %s', os.path.basename(sym_file), e) |
Mike Frysinger | eb753bf | 2013-11-22 16:05:35 -0500 | [diff] [blame] | 352 | finally: |
| 353 | if success: |
| 354 | _UpdateCounter(watermark_errors, ERROR_ADJUST_PASS) |
| 355 | else: |
| 356 | _UpdateCounter(num_errors, 1) |
| 357 | _UpdateCounter(watermark_errors, ERROR_ADJUST_FAIL) |
Mike Frysinger | 02e9240 | 2013-11-22 16:22:02 -0500 | [diff] [blame] | 358 | if failed_queue: |
| 359 | failed_queue.put(sym_file) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 360 | |
| 361 | return num_errors.value |
| 362 | |
| 363 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 364 | # A dummy class that allows for stubbing in tests and SymUpload. |
| 365 | FakeItem = cros_build_lib.Collection( |
| 366 | 'FakeItem', sym_file=None, sym_header=None, content=lambda x: '') |
| 367 | |
| 368 | |
Mike Frysinger | c5597f2 | 2014-11-27 15:39:15 -0500 | [diff] [blame] | 369 | class SymbolItem(isolateserver.BufferItem): |
| 370 | """Turn a sym_file into an isolateserver.Item""" |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 371 | |
Mike Frysinger | c5597f2 | 2014-11-27 15:39:15 -0500 | [diff] [blame] | 372 | ALGO = hashlib.sha1 |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 373 | |
Mike Frysinger | c5597f2 | 2014-11-27 15:39:15 -0500 | [diff] [blame] | 374 | def __init__(self, sym_file): |
| 375 | sym_header = cros_generate_breakpad_symbols.ReadSymsHeader(sym_file) |
| 376 | super(SymbolItem, self).__init__(str(sym_header), self.ALGO) |
| 377 | self.sym_header = sym_header |
| 378 | self.sym_file = sym_file |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 379 | |
| 380 | |
| 381 | def SymbolDeduplicatorNotify(dedupe_namespace, dedupe_queue): |
| 382 | """Send a symbol file to the swarming service |
| 383 | |
| 384 | Notify the swarming service of a successful upload. If the notification fails |
| 385 | for any reason, we ignore it. We don't care as it just means we'll upload it |
| 386 | again later on, and the symbol server will handle that graciously. |
| 387 | |
| 388 | This func runs in a different process from the main one, so we cannot share |
| 389 | the storage object. Instead, we create our own. This func stays alive for |
| 390 | the life of the process, so we only create one here overall. |
| 391 | |
| 392 | Args: |
| 393 | dedupe_namespace: The isolateserver namespace to dedupe uploaded symbols. |
| 394 | dedupe_queue: The queue to read SymbolItems from |
| 395 | """ |
| 396 | if dedupe_queue is None: |
| 397 | return |
| 398 | |
| 399 | item = None |
| 400 | try: |
Mike Frysinger | 650e672 | 2014-04-28 18:29:15 -0400 | [diff] [blame] | 401 | with timeout_util.Timeout(DEDUPE_TIMEOUT): |
| 402 | storage = isolateserver.get_storage_api(constants.ISOLATESERVER, |
| 403 | dedupe_namespace) |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 404 | for item in iter(dedupe_queue.get, None): |
| 405 | with timeout_util.Timeout(DEDUPE_TIMEOUT): |
Ralph Nathan | 5a582ff | 2015-03-20 18:18:30 -0700 | [diff] [blame] | 406 | logging.debug('sending %s to dedupe server', item.sym_file) |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 407 | storage.push(item, item.content(0)) |
Ralph Nathan | 5a582ff | 2015-03-20 18:18:30 -0700 | [diff] [blame] | 408 | logging.debug('sent %s', item.sym_file) |
Ralph Nathan | 0304728 | 2015-03-23 11:09:32 -0700 | [diff] [blame] | 409 | logging.info('dedupe notification finished; exiting') |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 410 | except Exception: |
| 411 | sym_file = item.sym_file if (item and item.sym_file) else '' |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 412 | logging.warning('posting %s to dedupe server failed', |
| 413 | os.path.basename(sym_file), exc_info=True) |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 414 | |
Mike Frysinger | 58312e9 | 2014-03-18 04:18:36 -0400 | [diff] [blame] | 415 | # Keep draining the queue though so it doesn't fill up. |
| 416 | while dedupe_queue.get() is not None: |
| 417 | continue |
| 418 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 419 | |
| 420 | def SymbolDeduplicator(storage, sym_paths): |
| 421 | """Filter out symbol files that we've already uploaded |
| 422 | |
| 423 | Using the swarming service, ask it to tell us which symbol files we've already |
| 424 | uploaded in previous runs and/or by other bots. If the query fails for any |
| 425 | reason, we'll just upload all symbols. This is fine as the symbol server will |
| 426 | do the right thing and this phase is purely an optimization. |
| 427 | |
| 428 | This code runs in the main thread which is why we can re-use the existing |
| 429 | storage object. Saves us from having to recreate one all the time. |
| 430 | |
| 431 | Args: |
| 432 | storage: An isolateserver.StorageApi object |
| 433 | sym_paths: List of symbol files to check against the dedupe server |
| 434 | |
| 435 | Returns: |
| 436 | List of symbol files that have not been uploaded before |
| 437 | """ |
| 438 | if not sym_paths: |
| 439 | return sym_paths |
| 440 | |
| 441 | items = [SymbolItem(x) for x in sym_paths] |
| 442 | if storage: |
| 443 | try: |
| 444 | with timeout_util.Timeout(DEDUPE_TIMEOUT): |
| 445 | items = storage.contains(items) |
| 446 | except Exception: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 447 | logging.warning('talking to dedupe server failed', exc_info=True) |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 448 | |
| 449 | return items |
| 450 | |
| 451 | |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 452 | def IsTarball(path): |
| 453 | """Guess if this is a tarball based on the filename.""" |
| 454 | parts = path.split('.') |
| 455 | if len(parts) <= 1: |
| 456 | return False |
| 457 | |
| 458 | if parts[-1] == 'tar': |
| 459 | return True |
| 460 | |
| 461 | if parts[-2] == 'tar': |
| 462 | return parts[-1] in ('bz2', 'gz', 'xz') |
| 463 | |
| 464 | return parts[-1] in ('tbz2', 'tbz', 'tgz', 'txz') |
| 465 | |
| 466 | |
| 467 | def SymbolFinder(tempdir, paths): |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 468 | """Locate symbol files in |paths| |
| 469 | |
| 470 | Args: |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 471 | tempdir: Path to use for temporary files (caller will clean up). |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 472 | paths: A list of input paths to walk. Files are returned w/out any checks. |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 473 | Dirs are searched for files that end in ".sym". Urls are fetched and then |
| 474 | processed. Tarballs are unpacked and walked. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 475 | |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 476 | Returns: |
| 477 | Yield every viable sym file. |
| 478 | """ |
Mike Frysinger | e847efd | 2015-01-08 03:57:24 -0500 | [diff] [blame] | 479 | cache_dir = commandline.GetCacheDir() |
| 480 | common_path = os.path.join(cache_dir, constants.COMMON_CACHE) |
| 481 | tar_cache = cache.TarballCache(common_path) |
| 482 | |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 483 | for p in paths: |
Don Garrett | 25f309a | 2014-03-19 14:02:12 -0700 | [diff] [blame] | 484 | # Pylint is confused about members of ParseResult. |
Don Garrett | f8bf784 | 2014-03-20 17:03:42 -0700 | [diff] [blame] | 485 | |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 486 | o = urlparse.urlparse(p) |
Don Garrett | f8bf784 | 2014-03-20 17:03:42 -0700 | [diff] [blame] | 487 | if o.scheme: # pylint: disable=E1101 |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 488 | # Support globs of filenames. |
| 489 | ctx = gs.GSContext() |
| 490 | for p in ctx.LS(p): |
Ralph Nathan | 0304728 | 2015-03-23 11:09:32 -0700 | [diff] [blame] | 491 | logging.info('processing files inside %s', p) |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 492 | o = urlparse.urlparse(p) |
Don Garrett | f8bf784 | 2014-03-20 17:03:42 -0700 | [diff] [blame] | 493 | key = ('%s%s' % (o.netloc, o.path)).split('/') # pylint: disable=E1101 |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 494 | # The common cache will not be LRU, removing the need to hold a read |
| 495 | # lock on the cached gsutil. |
| 496 | ref = tar_cache.Lookup(key) |
| 497 | try: |
| 498 | ref.SetDefault(p) |
| 499 | except cros_build_lib.RunCommandError as e: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 500 | logging.warning('ignoring %s\n%s', p, e) |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 501 | continue |
| 502 | for p in SymbolFinder(tempdir, [ref.path]): |
| 503 | yield p |
| 504 | |
| 505 | elif os.path.isdir(p): |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 506 | for root, _, files in os.walk(p): |
| 507 | for f in files: |
| 508 | if f.endswith('.sym'): |
| 509 | yield os.path.join(root, f) |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 510 | |
| 511 | elif IsTarball(p): |
Ralph Nathan | 0304728 | 2015-03-23 11:09:32 -0700 | [diff] [blame] | 512 | logging.info('processing files inside %s', p) |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 513 | tardir = tempfile.mkdtemp(dir=tempdir) |
| 514 | cache.Untar(os.path.realpath(p), tardir) |
| 515 | for p in SymbolFinder(tardir, [tardir]): |
| 516 | yield p |
| 517 | |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 518 | else: |
| 519 | yield p |
| 520 | |
| 521 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 522 | def WriteQueueToFile(listing, queue, relpath=None): |
| 523 | """Write all the items in |queue| to the |listing|. |
| 524 | |
Mike Frysinger | 5e6dd71 | 2014-03-07 22:21:17 -0500 | [diff] [blame] | 525 | Note: The queue must have a sentinel None appended to the end. |
| 526 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 527 | Args: |
| 528 | listing: Where to write out the list of files. |
| 529 | queue: The queue of paths to drain. |
| 530 | relpath: If set, write out paths relative to this one. |
| 531 | """ |
| 532 | if not listing: |
Mike Frysinger | a0ddac6 | 2014-03-14 10:30:25 -0400 | [diff] [blame] | 533 | # Still drain the queue so we make sure the producer has finished |
| 534 | # before we return. Otherwise, the queue might get destroyed too |
| 535 | # quickly which will trigger a traceback in the producer. |
| 536 | while queue.get() is not None: |
| 537 | continue |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 538 | return |
| 539 | |
| 540 | with cros_build_lib.Open(listing, 'wb+') as f: |
Mike Frysinger | 5e6dd71 | 2014-03-07 22:21:17 -0500 | [diff] [blame] | 541 | while True: |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 542 | path = queue.get() |
Mike Frysinger | 5e6dd71 | 2014-03-07 22:21:17 -0500 | [diff] [blame] | 543 | if path is None: |
| 544 | return |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 545 | if relpath: |
| 546 | path = os.path.relpath(path, relpath) |
| 547 | f.write('%s\n' % path) |
| 548 | |
| 549 | |
Mike Frysinger | 3864754 | 2014-09-12 18:15:39 -0700 | [diff] [blame] | 550 | def UploadSymbols(board=None, official=False, server=None, breakpad_dir=None, |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 551 | file_limit=DEFAULT_FILE_LIMIT, sleep=DEFAULT_SLEEP_DELAY, |
Mike Frysinger | 8ec8c50 | 2014-02-10 00:19:13 -0500 | [diff] [blame] | 552 | upload_limit=None, sym_paths=None, failed_list=None, |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 553 | root=None, retry=True, dedupe_namespace=None): |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 554 | """Upload all the generated symbols for |board| to the crash server |
| 555 | |
Mike Frysinger | 9dcf9ae | 2013-08-10 15:17:09 -0400 | [diff] [blame] | 556 | You can use in a few ways: |
| 557 | * pass |board| to locate all of its symbols |
| 558 | * pass |breakpad_dir| to upload all the symbols in there |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 559 | * pass |sym_paths| to upload specific symbols (or dirs of symbols) |
Mike Frysinger | 9dcf9ae | 2013-08-10 15:17:09 -0400 | [diff] [blame] | 560 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 561 | Args: |
| 562 | board: The board whose symbols we wish to upload |
| 563 | official: Use the official symbol server rather than the staging one |
Mike Frysinger | 3864754 | 2014-09-12 18:15:39 -0700 | [diff] [blame] | 564 | server: Explicit server to post symbols to |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 565 | breakpad_dir: The full path to the breakpad directory where symbols live |
| 566 | file_limit: The max file size of a symbol file before we try to strip it |
| 567 | sleep: How long to sleep in between uploads |
Mike Frysinger | 8ec8c50 | 2014-02-10 00:19:13 -0500 | [diff] [blame] | 568 | upload_limit: If set, only upload this many symbols (meant for testing) |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 569 | sym_paths: Specific symbol files (or dirs of sym files) to upload, |
| 570 | otherwise search |breakpad_dir| |
Mike Frysinger | 7f9be14 | 2014-01-15 02:16:42 -0500 | [diff] [blame] | 571 | failed_list: Write the names of all sym files we did not upload; can be a |
| 572 | filename or file-like object. |
Mike Frysinger | 118d250 | 2013-08-19 03:36:56 -0400 | [diff] [blame] | 573 | root: The tree to prefix to |breakpad_dir| (if |breakpad_dir| is not set) |
Mike Frysinger | 02e9240 | 2013-11-22 16:22:02 -0500 | [diff] [blame] | 574 | retry: Whether we should retry failures. |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 575 | dedupe_namespace: The isolateserver namespace to dedupe uploaded symbols. |
Mike Frysinger | 1a736a8 | 2013-12-12 01:50:59 -0500 | [diff] [blame] | 576 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 577 | Returns: |
Mike Frysinger | 69cb41d | 2013-08-11 20:08:19 -0400 | [diff] [blame] | 578 | The number of errors that were encountered. |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 579 | """ |
Mike Frysinger | 3864754 | 2014-09-12 18:15:39 -0700 | [diff] [blame] | 580 | if server is None: |
| 581 | if official: |
| 582 | upload_url = OFFICIAL_UPLOAD_URL |
| 583 | else: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 584 | logging.warning('unofficial builds upload to the staging server') |
Mike Frysinger | 3864754 | 2014-09-12 18:15:39 -0700 | [diff] [blame] | 585 | upload_url = STAGING_UPLOAD_URL |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 586 | else: |
Mike Frysinger | 3864754 | 2014-09-12 18:15:39 -0700 | [diff] [blame] | 587 | upload_url = server |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 588 | |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 589 | if sym_paths: |
Ralph Nathan | 0304728 | 2015-03-23 11:09:32 -0700 | [diff] [blame] | 590 | logging.info('uploading specified symbols to %s', upload_url) |
Mike Frysinger | 9dcf9ae | 2013-08-10 15:17:09 -0400 | [diff] [blame] | 591 | else: |
| 592 | if breakpad_dir is None: |
Mike Frysinger | c5597f2 | 2014-11-27 15:39:15 -0500 | [diff] [blame] | 593 | if root is None: |
| 594 | raise ValueError('breakpad_dir requires root to be set') |
Mike Frysinger | 118d250 | 2013-08-19 03:36:56 -0400 | [diff] [blame] | 595 | breakpad_dir = os.path.join( |
| 596 | root, |
| 597 | cros_generate_breakpad_symbols.FindBreakpadDir(board).lstrip('/')) |
Ralph Nathan | 0304728 | 2015-03-23 11:09:32 -0700 | [diff] [blame] | 598 | logging.info('uploading all symbols to %s from %s', upload_url, |
| 599 | breakpad_dir) |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 600 | sym_paths = [breakpad_dir] |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 601 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 602 | # We use storage_query to ask the server about existing symbols. The |
| 603 | # storage_notify_proc process is used to post updates to the server. We |
| 604 | # cannot safely share the storage object between threads/processes, but |
| 605 | # we also want to minimize creating new ones as each object has to init |
| 606 | # new state (like server connections). |
Mike Frysinger | 650e672 | 2014-04-28 18:29:15 -0400 | [diff] [blame] | 607 | storage_query = None |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 608 | if dedupe_namespace: |
| 609 | dedupe_limit = DEDUPE_LIMIT |
| 610 | dedupe_queue = multiprocessing.Queue() |
Mike Frysinger | 650e672 | 2014-04-28 18:29:15 -0400 | [diff] [blame] | 611 | try: |
| 612 | with timeout_util.Timeout(DEDUPE_TIMEOUT): |
| 613 | storage_query = isolateserver.get_storage_api(constants.ISOLATESERVER, |
| 614 | dedupe_namespace) |
| 615 | except Exception: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 616 | logging.warning('initializing dedupe server connection failed', |
| 617 | exc_info=True) |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 618 | else: |
| 619 | dedupe_limit = 1 |
Mike Frysinger | 650e672 | 2014-04-28 18:29:15 -0400 | [diff] [blame] | 620 | dedupe_queue = None |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 621 | # Can't use parallel.BackgroundTaskRunner because that'll create multiple |
| 622 | # processes and we want only one the whole time (see comment above). |
| 623 | storage_notify_proc = multiprocessing.Process( |
| 624 | target=SymbolDeduplicatorNotify, args=(dedupe_namespace, dedupe_queue)) |
| 625 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 626 | bg_errors = multiprocessing.Value('i') |
Mike Frysinger | eb753bf | 2013-11-22 16:05:35 -0500 | [diff] [blame] | 627 | watermark_errors = multiprocessing.Value('f') |
Mike Frysinger | 02e9240 | 2013-11-22 16:22:02 -0500 | [diff] [blame] | 628 | failed_queue = multiprocessing.Queue() |
| 629 | uploader = functools.partial( |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 630 | UploadSymbol, upload_url, file_limit=file_limit, sleep=sleep, |
| 631 | num_errors=bg_errors, watermark_errors=watermark_errors, |
| 632 | failed_queue=failed_queue, passed_queue=dedupe_queue) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 633 | |
Mike Frysinger | 8ec8c50 | 2014-02-10 00:19:13 -0500 | [diff] [blame] | 634 | start_time = datetime.datetime.now() |
| 635 | Counters = cros_build_lib.Collection( |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 636 | 'Counters', upload_limit=upload_limit, uploaded_count=0, deduped_count=0) |
Mike Frysinger | 8ec8c50 | 2014-02-10 00:19:13 -0500 | [diff] [blame] | 637 | counters = Counters() |
| 638 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 639 | def _Upload(queue, counters, files): |
| 640 | if not files: |
| 641 | return |
| 642 | |
| 643 | missing_count = 0 |
| 644 | for item in SymbolDeduplicator(storage_query, files): |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 645 | missing_count += 1 |
Mike Frysinger | d42e5f0 | 2014-03-14 11:19:37 -0400 | [diff] [blame] | 646 | |
| 647 | if counters.upload_limit == 0: |
| 648 | continue |
| 649 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 650 | queue.put((item,)) |
| 651 | counters.uploaded_count += 1 |
| 652 | if counters.upload_limit is not None: |
| 653 | counters.upload_limit -= 1 |
| 654 | |
| 655 | counters.deduped_count += (len(files) - missing_count) |
| 656 | |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 657 | try: |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 658 | storage_notify_proc.start() |
Mike Frysinger | 02e9240 | 2013-11-22 16:22:02 -0500 | [diff] [blame] | 659 | |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 660 | with osutils.TempDir(prefix='upload_symbols.') as tempdir: |
| 661 | # For the first run, we collect the symbols that failed. If the |
| 662 | # overall failure rate was low, we'll retry them on the second run. |
| 663 | for retry in (retry, False): |
| 664 | # We need to limit ourselves to one upload at a time to avoid the server |
| 665 | # kicking in DoS protection. See these bugs for more details: |
| 666 | # http://crbug.com/209442 |
| 667 | # http://crbug.com/212496 |
| 668 | with parallel.BackgroundTaskRunner(uploader, processes=1) as queue: |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 669 | dedupe_list = [] |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 670 | for sym_file in SymbolFinder(tempdir, sym_paths): |
| 671 | dedupe_list.append(sym_file) |
| 672 | dedupe_len = len(dedupe_list) |
| 673 | if dedupe_len < dedupe_limit: |
| 674 | if (counters.upload_limit is None or |
| 675 | dedupe_len < counters.upload_limit): |
| 676 | continue |
Mike Frysinger | 02e9240 | 2013-11-22 16:22:02 -0500 | [diff] [blame] | 677 | |
Mike Frysinger | 1010a89 | 2014-03-14 11:24:17 -0400 | [diff] [blame] | 678 | # We check the counter before _Upload so that we don't keep talking |
| 679 | # to the dedupe server. Otherwise, we end up sending one symbol at |
| 680 | # a time to it and that slows things down a lot. |
| 681 | if counters.upload_limit == 0: |
| 682 | break |
| 683 | |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 684 | _Upload(queue, counters, dedupe_list) |
| 685 | dedupe_list = [] |
| 686 | _Upload(queue, counters, dedupe_list) |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 687 | |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 688 | # See if we need to retry, and if we haven't failed too many times yet. |
| 689 | if not retry or ErrorLimitHit(bg_errors, watermark_errors): |
Mike Frysinger | 5e6dd71 | 2014-03-07 22:21:17 -0500 | [diff] [blame] | 690 | break |
Mike Frysinger | 5e6dd71 | 2014-03-07 22:21:17 -0500 | [diff] [blame] | 691 | |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 692 | sym_paths = [] |
| 693 | failed_queue.put(None) |
| 694 | while True: |
| 695 | sym_path = failed_queue.get() |
| 696 | if sym_path is None: |
| 697 | break |
| 698 | sym_paths.append(sym_path) |
Mike Frysinger | 02e9240 | 2013-11-22 16:22:02 -0500 | [diff] [blame] | 699 | |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 700 | if sym_paths: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 701 | logging.warning('retrying %i symbols', len(sym_paths)) |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 702 | if counters.upload_limit is not None: |
| 703 | counters.upload_limit += len(sym_paths) |
| 704 | # Decrement the error count in case we recover in the second pass. |
| 705 | assert bg_errors.value >= len(sym_paths), \ |
| 706 | 'more failed files than errors?' |
| 707 | bg_errors.value -= len(sym_paths) |
| 708 | else: |
| 709 | # No failed symbols, so just return now. |
| 710 | break |
Mike Frysinger | 7f9be14 | 2014-01-15 02:16:42 -0500 | [diff] [blame] | 711 | |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 712 | # If the user has requested it, save all the symbol files that we failed to |
| 713 | # upload to a listing file. This should help with recovery efforts later. |
| 714 | failed_queue.put(None) |
| 715 | WriteQueueToFile(failed_list, failed_queue, breakpad_dir) |
| 716 | |
| 717 | finally: |
Ralph Nathan | 0304728 | 2015-03-23 11:09:32 -0700 | [diff] [blame] | 718 | logging.info('finished uploading; joining background process') |
Mike Frysinger | 1387008 | 2014-03-14 10:41:20 -0400 | [diff] [blame] | 719 | if dedupe_queue: |
| 720 | dedupe_queue.put(None) |
Mike Frysinger | 4dd462e | 2014-04-30 16:21:51 -0400 | [diff] [blame] | 721 | |
| 722 | # The notification might be slow going, so give it some time to finish. |
| 723 | # We have to poll here as the process monitor is watching for output and |
| 724 | # will kill us if we go silent for too long. |
| 725 | wait_minutes = DEDUPE_NOTIFY_TIMEOUT |
| 726 | while storage_notify_proc.is_alive() and wait_minutes > 0: |
Aviv Keshet | d1f0463 | 2014-05-09 11:33:46 -0700 | [diff] [blame] | 727 | if dedupe_queue: |
| 728 | qsize = str(dedupe_queue.qsize()) |
| 729 | else: |
| 730 | qsize = '[None]' |
Ralph Nathan | 0304728 | 2015-03-23 11:09:32 -0700 | [diff] [blame] | 731 | logging.info('waiting up to %i minutes for ~%s notifications', |
| 732 | wait_minutes, qsize) |
Mike Frysinger | 4dd462e | 2014-04-30 16:21:51 -0400 | [diff] [blame] | 733 | storage_notify_proc.join(60) |
| 734 | wait_minutes -= 1 |
| 735 | |
| 736 | # The process is taking too long, so kill it and complain. |
| 737 | if storage_notify_proc.is_alive(): |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 738 | logging.warning('notification process took too long') |
Mike Frysinger | 4dd462e | 2014-04-30 16:21:51 -0400 | [diff] [blame] | 739 | cros_build_lib.PrintBuildbotStepWarnings() |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 740 | |
Mike Frysinger | 66e51e9 | 2014-05-03 16:52:00 -0400 | [diff] [blame] | 741 | # Kill it gracefully first (traceback) before tacking it down harder. |
| 742 | pid = storage_notify_proc.pid |
| 743 | for sig in (signal.SIGINT, signal.SIGTERM, signal.SIGKILL): |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 744 | logging.warning('sending %s to %i', signals.StrSignal(sig), pid) |
Mike Frysinger | dad2a03 | 2014-05-11 23:05:11 -0400 | [diff] [blame] | 745 | # The process might have exited between the last check and the |
| 746 | # actual kill below, so ignore ESRCH errors. |
| 747 | try: |
| 748 | os.kill(pid, sig) |
| 749 | except OSError as e: |
| 750 | if e.errno == errno.ESRCH: |
| 751 | break |
| 752 | else: |
| 753 | raise |
Mike Frysinger | 66e51e9 | 2014-05-03 16:52:00 -0400 | [diff] [blame] | 754 | time.sleep(5) |
Mike Frysinger | dad2a03 | 2014-05-11 23:05:11 -0400 | [diff] [blame] | 755 | if not storage_notify_proc.is_alive(): |
Mike Frysinger | 66e51e9 | 2014-05-03 16:52:00 -0400 | [diff] [blame] | 756 | break |
| 757 | |
| 758 | # Drain the queue so we don't hang when we finish. |
| 759 | try: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 760 | logging.warning('draining the notify queue manually') |
Mike Frysinger | 4f5ea83 | 2014-05-12 00:54:28 -0400 | [diff] [blame] | 761 | with timeout_util.Timeout(60): |
| 762 | try: |
| 763 | while dedupe_queue.get_nowait(): |
| 764 | pass |
| 765 | except Queue.Empty: |
| 766 | pass |
| 767 | except timeout_util.TimeoutError: |
Ralph Nathan | 446aee9 | 2015-03-23 14:44:56 -0700 | [diff] [blame] | 768 | logging.warning('draining the notify queue failed; trashing it') |
Mike Frysinger | 4f5ea83 | 2014-05-12 00:54:28 -0400 | [diff] [blame] | 769 | dedupe_queue.cancel_join_thread() |
Mike Frysinger | 66e51e9 | 2014-05-03 16:52:00 -0400 | [diff] [blame] | 770 | |
Ralph Nathan | 0304728 | 2015-03-23 11:09:32 -0700 | [diff] [blame] | 771 | logging.info('uploaded %i symbols (%i were deduped) which took: %s', |
| 772 | counters.uploaded_count, counters.deduped_count, |
| 773 | datetime.datetime.now() - start_time) |
Mike Frysinger | 8ec8c50 | 2014-02-10 00:19:13 -0500 | [diff] [blame] | 774 | |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 775 | return bg_errors.value |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 776 | |
| 777 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 778 | def main(argv): |
| 779 | parser = commandline.ArgumentParser(description=__doc__) |
| 780 | |
Mike Frysinger | d41938e | 2014-02-10 06:37:55 -0500 | [diff] [blame] | 781 | parser.add_argument('sym_paths', type='path_or_uri', nargs='*', default=None, |
| 782 | help='symbol file or directory or URL or tarball') |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 783 | parser.add_argument('--board', default=None, |
| 784 | help='board to build packages for') |
| 785 | parser.add_argument('--breakpad_root', type='path', default=None, |
Mike Frysinger | c5597f2 | 2014-11-27 15:39:15 -0500 | [diff] [blame] | 786 | help='full path to the breakpad symbol directory') |
| 787 | parser.add_argument('--root', type='path', default=None, |
| 788 | help='full path to the chroot dir') |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 789 | parser.add_argument('--official_build', action='store_true', default=False, |
| 790 | help='point to official symbol server') |
Mike Frysinger | 3864754 | 2014-09-12 18:15:39 -0700 | [diff] [blame] | 791 | parser.add_argument('--server', type=str, default=None, |
| 792 | help='URI for custom symbol server') |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 793 | parser.add_argument('--regenerate', action='store_true', default=False, |
| 794 | help='regenerate all symbols') |
Mike Frysinger | 8ec8c50 | 2014-02-10 00:19:13 -0500 | [diff] [blame] | 795 | parser.add_argument('--upload-limit', type=int, default=None, |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 796 | help='only upload # number of symbols') |
| 797 | parser.add_argument('--strip_cfi', type=int, |
| 798 | default=CRASH_SERVER_FILE_LIMIT - (10 * 1024 * 1024), |
| 799 | help='strip CFI data for files above this size') |
Mike Frysinger | 7f9be14 | 2014-01-15 02:16:42 -0500 | [diff] [blame] | 800 | parser.add_argument('--failed-list', type='path', |
| 801 | help='where to save a list of failed symbols') |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 802 | parser.add_argument('--dedupe', action='store_true', default=False, |
| 803 | help='use the swarming service to avoid re-uploading') |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 804 | parser.add_argument('--testing', action='store_true', default=False, |
| 805 | help='run in testing mode') |
| 806 | parser.add_argument('--yes', action='store_true', default=False, |
| 807 | help='answer yes to all prompts') |
| 808 | |
| 809 | opts = parser.parse_args(argv) |
Mike Frysinger | 90e49ca | 2014-01-14 14:42:07 -0500 | [diff] [blame] | 810 | opts.Freeze() |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 811 | |
Mike Frysinger | 9b2ff5c | 2013-11-22 10:01:12 -0500 | [diff] [blame] | 812 | if opts.sym_paths: |
Mike Frysinger | 9dcf9ae | 2013-08-10 15:17:09 -0400 | [diff] [blame] | 813 | if opts.regenerate: |
| 814 | cros_build_lib.Die('--regenerate may not be used with specific files') |
| 815 | else: |
| 816 | if opts.board is None: |
| 817 | cros_build_lib.Die('--board is required') |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 818 | |
| 819 | if opts.breakpad_root and opts.regenerate: |
| 820 | cros_build_lib.Die('--regenerate may not be used with --breakpad_root') |
| 821 | |
| 822 | if opts.testing: |
| 823 | # TODO(build): Kill off --testing mode once unittests are up-to-snuff. |
Ralph Nathan | 0304728 | 2015-03-23 11:09:32 -0700 | [diff] [blame] | 824 | logging.info('running in testing mode') |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 825 | # pylint: disable=W0601,W0603 |
| 826 | global INITIAL_RETRY_DELAY, SymUpload, DEFAULT_SLEEP_DELAY |
| 827 | INITIAL_RETRY_DELAY = DEFAULT_SLEEP_DELAY = 0 |
| 828 | SymUpload = TestingSymUpload |
| 829 | |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 830 | dedupe_namespace = None |
| 831 | if opts.dedupe: |
| 832 | if opts.official_build and not opts.testing: |
| 833 | dedupe_namespace = OFFICIAL_DEDUPE_NAMESPACE |
| 834 | else: |
| 835 | dedupe_namespace = STAGING_DEDUPE_NAMESPACE |
| 836 | |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 837 | if not opts.yes: |
Mike Frysinger | c5de960 | 2014-02-09 02:42:36 -0500 | [diff] [blame] | 838 | prolog = '\n'.join(textwrap.wrap(textwrap.dedent(""" |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 839 | Uploading symbols for an entire Chromium OS build is really only |
| 840 | necessary for release builds and in a few cases for developers |
| 841 | to debug problems. It will take considerable time to run. For |
| 842 | developer debugging purposes, consider instead passing specific |
| 843 | files to upload. |
Mike Frysinger | c5de960 | 2014-02-09 02:42:36 -0500 | [diff] [blame] | 844 | """), 80)).strip() |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 845 | if not cros_build_lib.BooleanPrompt( |
| 846 | prompt='Are you sure you want to upload all build symbols', |
Mike Frysinger | c5de960 | 2014-02-09 02:42:36 -0500 | [diff] [blame] | 847 | default=False, prolog=prolog): |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 848 | cros_build_lib.Die('better safe than sorry') |
| 849 | |
| 850 | ret = 0 |
| 851 | if opts.regenerate: |
Mike Frysinger | 69cb41d | 2013-08-11 20:08:19 -0400 | [diff] [blame] | 852 | ret += cros_generate_breakpad_symbols.GenerateBreakpadSymbols( |
| 853 | opts.board, breakpad_dir=opts.breakpad_root) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 854 | |
| 855 | ret += UploadSymbols(opts.board, official=opts.official_build, |
Mike Frysinger | 3864754 | 2014-09-12 18:15:39 -0700 | [diff] [blame] | 856 | server=opts.server, breakpad_dir=opts.breakpad_root, |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 857 | file_limit=opts.strip_cfi, sleep=DEFAULT_SLEEP_DELAY, |
Mike Frysinger | 8ec8c50 | 2014-02-10 00:19:13 -0500 | [diff] [blame] | 858 | upload_limit=opts.upload_limit, sym_paths=opts.sym_paths, |
Mike Frysinger | c5597f2 | 2014-11-27 15:39:15 -0500 | [diff] [blame] | 859 | failed_list=opts.failed_list, root=opts.root, |
Mike Frysinger | 0c0efa2 | 2014-02-09 23:32:23 -0500 | [diff] [blame] | 860 | dedupe_namespace=dedupe_namespace) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 861 | if ret: |
Ralph Nathan | 5990042 | 2015-03-24 10:41:17 -0700 | [diff] [blame] | 862 | logging.error('encountered %i problem(s)', ret) |
Mike Frysinger | d5fcb3a | 2013-05-30 21:10:50 -0400 | [diff] [blame] | 863 | # Since exit(status) gets masked, clamp it to 1 so we don't inadvertently |
| 864 | # return 0 in case we are a multiple of the mask. |
| 865 | ret = 1 |
| 866 | |
| 867 | return ret |
Mike Frysinger | 094a217 | 2013-08-14 12:54:35 -0400 | [diff] [blame] | 868 | |
| 869 | |
| 870 | # We need this to run once per process. Do it at module import time as that |
| 871 | # will let us avoid doing it inline at function call time (see SymUpload) as |
| 872 | # that func might be called by the multiprocessing module which means we'll |
| 873 | # do the opener logic multiple times overall. Plus, if you're importing this |
| 874 | # module, it's a pretty good chance that you're going to need this. |
| 875 | poster.streaminghttp.register_openers() |