Mike Frysinger | e58c0e2 | 2017-10-04 15:43:30 -0400 | [diff] [blame] | 1 | # -*- coding: utf-8 -*- |
Mike Frysinger | 6cb624a | 2012-05-24 18:17:38 -0400 | [diff] [blame] | 2 | # Copyright (c) 2012 The Chromium OS Authors. All rights reserved. |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | """Unit tests for cros_mark_as_stable.py.""" |
| 7 | |
Mike Frysinger | 383367e | 2014-09-16 15:06:17 -0400 | [diff] [blame] | 8 | from __future__ import print_function |
| 9 | |
Mike Frysinger | ea838d1 | 2014-12-08 11:55:32 -0500 | [diff] [blame] | 10 | import mock |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 11 | |
J. Richard Barnette | d422f62 | 2011-11-17 09:39:46 -0800 | [diff] [blame] | 12 | from chromite.lib import cros_build_lib |
Mike Frysinger | de5ab0e | 2013-03-21 20:48:36 -0400 | [diff] [blame] | 13 | from chromite.lib import cros_build_lib_unittest |
Brian Harring | c92788f | 2012-09-21 18:07:15 -0700 | [diff] [blame] | 14 | from chromite.lib import cros_test_lib |
David James | 97d9587 | 2012-11-16 15:09:56 -0800 | [diff] [blame] | 15 | from chromite.lib import git |
David James | 59a0a2b | 2013-03-22 14:04:44 -0700 | [diff] [blame] | 16 | from chromite.lib import osutils |
Mike Frysinger | de5ab0e | 2013-03-21 20:48:36 -0400 | [diff] [blame] | 17 | from chromite.lib import parallel_unittest |
| 18 | from chromite.lib import partial_mock |
Mike Frysinger | 6cb624a | 2012-05-24 18:17:38 -0400 | [diff] [blame] | 19 | from chromite.scripts import cros_mark_as_stable |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 20 | |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 21 | |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 22 | class RunGitMock(partial_mock.PartialCmdMock): |
| 23 | """Partial mock for git.RunMock.""" |
| 24 | TARGET = 'chromite.lib.git' |
| 25 | ATTRS = ('RunGit',) |
| 26 | DEFAULT_ATTR = 'RunGit' |
| 27 | |
| 28 | def RunGit(self, _git_repo, cmd, _retry=True, **kwargs): |
| 29 | return self._results['RunGit'].LookupResult( |
| 30 | (cmd,), hook_args=(cmd,), hook_kwargs=kwargs) |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 31 | |
| 32 | |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 33 | class NonClassTests(cros_test_lib.MockTestCase): |
Don Garrett | 25f309a | 2014-03-19 14:02:12 -0700 | [diff] [blame] | 34 | """Test the flow for pushing a change.""" |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 35 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 36 | def setUp(self): |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 37 | self._branch = 'test_branch' |
Brian Harring | eb23793 | 2012-05-07 02:08:06 -0700 | [diff] [blame] | 38 | self._target_manifest_branch = 'cros/master' |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 39 | |
Matt Tennant | cb52205 | 2013-11-25 14:23:43 -0800 | [diff] [blame] | 40 | def _TestPushChange(self, bad_cls): |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 41 | side_effect = Exception('unittest says this should not be called') |
| 42 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 43 | git_log = 'Marking test_one as stable\nMarking test_two as stable\n' |
| 44 | fake_description = 'Marking set of ebuilds as stable\n\n%s' % git_log |
David James | 4795963 | 2015-10-23 07:56:01 -0700 | [diff] [blame] | 45 | self.PatchObject(git, 'DoesCommitExistInRepo', return_value=True) |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 46 | self.PatchObject(cros_mark_as_stable, '_DoWeHaveLocalCommits', |
| 47 | return_value=True) |
| 48 | self.PatchObject(cros_mark_as_stable.GitBranch, 'CreateBranch', |
| 49 | side_effect=side_effect) |
| 50 | self.PatchObject(cros_mark_as_stable.GitBranch, 'Exists', |
| 51 | side_effect=side_effect) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 52 | |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 53 | push_mock = self.PatchObject(git, 'PushWithRetry') |
Don Garrett | 9944959 | 2015-03-25 11:01:30 -0700 | [diff] [blame] | 54 | self.PatchObject( |
| 55 | git, 'GetTrackingBranch', |
| 56 | return_value=git.RemoteRef('gerrit', 'refs/remotes/gerrit/master')) |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 57 | sync_mock = self.PatchObject(git, 'SyncPushBranch') |
| 58 | create_mock = self.PatchObject(git, 'CreatePushBranch') |
| 59 | git_mock = self.StartPatcher(RunGitMock()) |
Matt Tennant | cb52205 | 2013-11-25 14:23:43 -0800 | [diff] [blame] | 60 | |
Paul Hobbs | f52ea8f | 2015-10-21 17:24:23 -0700 | [diff] [blame] | 61 | git_mock.AddCmdResult(['checkout', self._branch]) |
| 62 | |
Matt Tennant | cb52205 | 2013-11-25 14:23:43 -0800 | [diff] [blame] | 63 | cmd = ['log', '--format=short', '--perl-regexp', '--author', |
| 64 | '^(?!chrome-bot)', 'refs/remotes/gerrit/master..%s' % self._branch] |
| 65 | |
| 66 | if bad_cls: |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 67 | push_mock.side_effect = side_effect |
| 68 | create_mock.side_effect = side_effect |
| 69 | git_mock.AddCmdResult(cmd, output='Found bad stuff') |
Matt Tennant | cb52205 | 2013-11-25 14:23:43 -0800 | [diff] [blame] | 70 | else: |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 71 | git_mock.AddCmdResult(cmd, output='\n') |
Matt Tennant | cb52205 | 2013-11-25 14:23:43 -0800 | [diff] [blame] | 72 | cmd = ['log', '--format=format:%s%n%n%b', |
| 73 | 'refs/remotes/gerrit/master..%s' % self._branch] |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 74 | git_mock.AddCmdResult(cmd, output=git_log) |
| 75 | git_mock.AddCmdResult(['merge', '--squash', self._branch]) |
| 76 | git_mock.AddCmdResult(['commit', '-m', fake_description]) |
| 77 | git_mock.AddCmdResult(['config', 'push.default', 'tracking']) |
Matt Tennant | cb52205 | 2013-11-25 14:23:43 -0800 | [diff] [blame] | 78 | |
Paul Hobbs | 72d8e39 | 2015-10-21 17:24:23 -0700 | [diff] [blame] | 79 | cros_mark_as_stable.PushChange(self._branch, self._target_manifest_branch, |
| 80 | False, '.') |
| 81 | sync_mock.assert_called_with('.', 'gerrit', 'refs/remotes/gerrit/master') |
| 82 | if not bad_cls: |
Ningning Xia | 5200906 | 2016-05-09 14:33:51 -0700 | [diff] [blame] | 83 | push_mock.assert_called_with('merge_branch', '.', dryrun=False, |
| 84 | staging_branch=None) |
Paul Hobbs | f52ea8f | 2015-10-21 17:24:23 -0700 | [diff] [blame] | 85 | create_mock.assert_called_with('merge_branch', '.', |
| 86 | remote_push_branch=mock.ANY) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 87 | |
Matt Tennant | cb52205 | 2013-11-25 14:23:43 -0800 | [diff] [blame] | 88 | def testPushChange(self): |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 89 | """Verify pushing changes works.""" |
Matt Tennant | cb52205 | 2013-11-25 14:23:43 -0800 | [diff] [blame] | 90 | self._TestPushChange(bad_cls=False) |
| 91 | |
| 92 | def testPushChangeBadCls(self): |
Mike Frysinger | c978534 | 2014-12-08 00:47:08 -0500 | [diff] [blame] | 93 | """Verify we do not push bad CLs.""" |
Matt Tennant | cb52205 | 2013-11-25 14:23:43 -0800 | [diff] [blame] | 94 | self.assertRaises(AssertionError, self._TestPushChange, bad_cls=True) |
| 95 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 96 | |
Mike Frysinger | de5ab0e | 2013-03-21 20:48:36 -0400 | [diff] [blame] | 97 | class CleanStalePackagesTest(cros_build_lib_unittest.RunCommandTestCase): |
Don Garrett | 25f309a | 2014-03-19 14:02:12 -0700 | [diff] [blame] | 98 | """Tests for cros_mark_as_stable.CleanStalePackages.""" |
Mike Frysinger | de5ab0e | 2013-03-21 20:48:36 -0400 | [diff] [blame] | 99 | |
David James | 59a0a2b | 2013-03-22 14:04:44 -0700 | [diff] [blame] | 100 | def setUp(self): |
| 101 | self.PatchObject(osutils, 'FindMissingBinaries', return_value=[]) |
| 102 | |
Mike Frysinger | de5ab0e | 2013-03-21 20:48:36 -0400 | [diff] [blame] | 103 | def testNormalClean(self): |
| 104 | """Clean up boards/packages with normal success""" |
David James | 41124af | 2015-06-04 21:13:25 -0700 | [diff] [blame] | 105 | cros_mark_as_stable.CleanStalePackages('.', ('board1', 'board2'), |
| 106 | ['cow', 'car']) |
Mike Frysinger | de5ab0e | 2013-03-21 20:48:36 -0400 | [diff] [blame] | 107 | |
| 108 | def testNothingToUnmerge(self): |
| 109 | """Clean up packages that don't exist (portage will exit 1)""" |
| 110 | self.rc.AddCmdResult(partial_mock.In('emerge'), returncode=1) |
David James | 41124af | 2015-06-04 21:13:25 -0700 | [diff] [blame] | 111 | cros_mark_as_stable.CleanStalePackages('.', (), ['no/pkg']) |
Mike Frysinger | de5ab0e | 2013-03-21 20:48:36 -0400 | [diff] [blame] | 112 | |
| 113 | def testUnmergeError(self): |
| 114 | """Make sure random exit errors are not ignored""" |
| 115 | self.rc.AddCmdResult(partial_mock.In('emerge'), returncode=123) |
| 116 | with parallel_unittest.ParallelMock(): |
| 117 | self.assertRaises(cros_build_lib.RunCommandError, |
David James | 59a0a2b | 2013-03-22 14:04:44 -0700 | [diff] [blame] | 118 | cros_mark_as_stable.CleanStalePackages, |
David James | 41124af | 2015-06-04 21:13:25 -0700 | [diff] [blame] | 119 | '.', (), ['no/pkg']) |
Mike Frysinger | de5ab0e | 2013-03-21 20:48:36 -0400 | [diff] [blame] | 120 | |
| 121 | |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 122 | class GitBranchTest(cros_test_lib.MockTestCase): |
Don Garrett | 25f309a | 2014-03-19 14:02:12 -0700 | [diff] [blame] | 123 | """Tests for cros_mark_as_stable.GitBranch.""" |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 124 | |
| 125 | def setUp(self): |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 126 | # Always stub RunCommmand out as we use it in every method. |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 127 | self.rc_mock = self.PatchObject(cros_build_lib, 'RunCommand') |
| 128 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 129 | self._branch_name = 'test_branch' |
Brian Harring | eb23793 | 2012-05-07 02:08:06 -0700 | [diff] [blame] | 130 | self._target_manifest_branch = 'cros/test' |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 131 | self._branch = cros_mark_as_stable.GitBranch( |
| 132 | branch_name=self._branch_name, |
| 133 | tracking_branch=self._target_manifest_branch, |
| 134 | cwd='.') |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 135 | |
| 136 | def testCheckoutCreate(self): |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 137 | """Test init with no previous branch existing.""" |
| 138 | self.PatchObject(self._branch, 'Exists', return_value=False) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 139 | cros_mark_as_stable.GitBranch.Checkout(self._branch) |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 140 | self.rc_mock.assert_call(mock.call( |
| 141 | ['repo', 'start', self._branch_name, '.'], |
| 142 | print_cmd=False, cwd='.', capture_output=True)) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 143 | |
| 144 | def testCheckoutNoCreate(self): |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 145 | """Test init with previous branch existing.""" |
| 146 | self.PatchObject(self._branch, 'Exists', return_value=True) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 147 | cros_mark_as_stable.GitBranch.Checkout(self._branch) |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 148 | self.rc_mock.assert_call(mock.call( |
| 149 | ['git', 'checkout', '-f', self._branch_name], |
| 150 | print_cmd=False, cwd='.', capture_output=True)) |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 151 | |
Chris Sosa | dad0d32 | 2011-01-31 16:37:33 -0800 | [diff] [blame] | 152 | def testExists(self): |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 153 | """Test if branch exists that is created.""" |
Mike Frysinger | 7dafd0e | 2012-05-08 15:47:16 -0400 | [diff] [blame] | 154 | result = cros_build_lib.CommandResult(output=self._branch_name + '\n') |
Mike Frysinger | ef6ccb2 | 2014-11-07 14:59:48 -0500 | [diff] [blame] | 155 | self.PatchObject(git, 'RunGit', return_value=result) |
| 156 | self.assertTrue(self._branch.Exists()) |