blob: 9842f32ba437a228383f17e929bfc122a3d4808d [file] [log] [blame]
Steven Bennettsddf9bcd2017-06-14 14:07:43 -07001# Copyright 2017 The Chromium OS Authors. All rights reserved.
2# Use of this source code is governed by a BSD-style license that can be
3# found in the LICENSE file.
4
5"""Unit tests for the chrome_chromeos_lkgm program."""
6
Ben Pastene6a8361a2021-08-19 19:52:05 -07007from unittest import mock
Ben Pasteneca7c71b2021-10-07 18:34:27 -07008import urllib.parse
Steven Bennettsddf9bcd2017-06-14 14:07:43 -07009
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070010from chromite.lib import cros_test_lib
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070011from chromite.scripts import chrome_chromeos_lkgm
12
Achuith Bhandarkarec8d7a72018-03-01 16:56:22 -080013
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070014# pylint: disable=protected-access
Benjamin Gordon121a2aa2018-05-04 16:24:45 -060015class ChromeLKGMCommitterTester(cros_test_lib.RunCommandTestCase,
Achuith Bhandarkardc3a3512018-03-16 15:10:57 -070016 cros_test_lib.MockTempDirTestCase):
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070017 """Test cros_chromeos_lkgm.Committer."""
Achuith Bhandarkarec8d7a72018-03-01 16:56:22 -080018
Achuith Bhandarkardc3a3512018-03-16 15:10:57 -070019 def setUp(self):
20 """Common set up method for all tests."""
21 self.committer = chrome_chromeos_lkgm.ChromeLKGMCommitter(
Ben Pastene769b1212021-12-14 18:26:50 -080022 'user@test.org', '1001.0.0')
Achuith Bhandarkardc3a3512018-03-16 15:10:57 -070023 self.old_lkgm = None
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070024
Ben Pastene769b1212021-12-14 18:26:50 -080025 @mock.patch('chromite.lib.gob_util.GetFileContentsOnHead')
26 def testCommitNewLKGM(self, mock_get_file):
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070027 """Tests that we can commit a new LKGM file."""
Ben Pastene769b1212021-12-14 18:26:50 -080028 mock_get_file.return_value = '999.0.0'
29 with mock.patch.object(self.committer._gerrit_helper, 'CreateChange') as cg:
30 cg.return_value = mock.MagicMock(gerrit_number=123456)
31 with mock.patch.object(self.committer._gerrit_helper, 'ChangeEdit') as ce:
Fergus Dall64a21b62022-01-07 13:50:26 +110032 with mock.patch.object(
33 self.committer._gerrit_helper, 'SetReview') as bc:
34 self.committer.UpdateLKGM()
35 ce.assert_called_once_with(123456, 'chromeos/CHROMEOS_LKGM',
36 '1001.0.0')
37 bc.assert_called_once_with(123456, labels={'Bot-Commit': 1},
38 notify='NONE')
Steven Bennettsddf9bcd2017-06-14 14:07:43 -070039
Ben Pastene769b1212021-12-14 18:26:50 -080040 @mock.patch('chromite.lib.gob_util.GetFileContentsOnHead')
41 def testOlderLKGMFails(self, mock_get_file):
Steven Bennetts4bc322a2017-08-28 09:37:39 -070042 """Tests that trying to update to an older lkgm version fails."""
Ben Pastene769b1212021-12-14 18:26:50 -080043 mock_get_file.return_value = '1002.0.0'
44 with mock.patch.object(self.committer._gerrit_helper, 'CreateChange') as cg:
45 cg.return_value = mock.MagicMock(gerrit_number=123456)
46 with mock.patch.object(self.committer._gerrit_helper, 'ChangeEdit') as ce:
47 self.assertRaises(chrome_chromeos_lkgm.LKGMNotValid,
48 self.committer.UpdateLKGM)
49 ce.assert_not_called()
Steven Bennetts4bc322a2017-08-28 09:37:39 -070050
Ben Pastene769b1212021-12-14 18:26:50 -080051 @mock.patch('chromite.lib.gob_util.GetFileContentsOnHead')
52 def testVersionWithChromeBranch(self, mock_get_file):
Steven Bennetts4bc322a2017-08-28 09:37:39 -070053 """Tests passing a version with a chrome branch strips the branch."""
Achuith Bhandarkar1b9180f2018-02-22 19:12:09 -080054 self.committer = chrome_chromeos_lkgm.ChromeLKGMCommitter(
Ben Pastene769b1212021-12-14 18:26:50 -080055 'user@test.org', '1003.0.0-rc2')
56 mock_get_file.return_value = '1002.0.0'
Steven Bennetts4bc322a2017-08-28 09:37:39 -070057
Ben Pastene769b1212021-12-14 18:26:50 -080058 with mock.patch.object(self.committer._gerrit_helper, 'CreateChange') as cg:
59 cg.return_value = mock.MagicMock(gerrit_number=123456)
60 with mock.patch.object(self.committer._gerrit_helper, 'ChangeEdit') as ce:
Fergus Dall64a21b62022-01-07 13:50:26 +110061 with mock.patch.object(
62 self.committer._gerrit_helper, 'SetReview') as bc:
63 # Check the file was actually written out correctly.
64 self.committer.UpdateLKGM()
65 ce.assert_called_once_with(123456, 'chromeos/CHROMEOS_LKGM',
66 '1003.0.0')
67 bc.assert_called_once_with(123456, labels={'Bot-Commit': 1},
68 notify='NONE')
Ben Pastened3b93d42019-10-10 09:56:29 -070069
70 def testCommitMsg(self):
71 """Tests format of the commit message."""
Ben Pastened3b93d42019-10-10 09:56:29 -070072 self.committer._PRESUBMIT_BOTS = ['bot1', 'bot2']
Ben Pastenef0fb0622021-09-24 23:38:13 +000073 self.committer._buildbucket_id = 'some-build-id'
Ben Pastened3b93d42019-10-10 09:56:29 -070074 commit_msg_lines = self.committer.ComposeCommitMsg().splitlines()
Ben Pastene769b1212021-12-14 18:26:50 -080075 self.assertIn(
76 'Automated Commit: LKGM 1001.0.0 for chromeos.', commit_msg_lines)
Ben Pastenef0fb0622021-09-24 23:38:13 +000077 self.assertIn(
78 'Uploaded by https://ci.chromium.org/b/some-build-id', commit_msg_lines)
Ben Pastened3b93d42019-10-10 09:56:29 -070079 self.assertIn('CQ_INCLUDE_TRYBOTS=luci.chrome.try:bot1', commit_msg_lines)
80 self.assertIn('CQ_INCLUDE_TRYBOTS=luci.chrome.try:bot2', commit_msg_lines)
Ben Pastene6a8361a2021-08-19 19:52:05 -070081
82 def testFindAlreadyOpenLKGMRoll(self):
83 already_open_issues = [123456]
Ben Pasteneca7c71b2021-10-07 18:34:27 -070084 self.committer._commit_msg_header = 'A message with spaces'
Ben Pastene6a8361a2021-08-19 19:52:05 -070085 with mock.patch.object(
86 self.committer._gerrit_helper, 'Query',
Ben Pasteneca7c71b2021-10-07 18:34:27 -070087 return_value=already_open_issues) as mock_query:
Ben Pastene6a8361a2021-08-19 19:52:05 -070088 self.assertEqual(
89 self.committer.FindAlreadyOpenLKGMRoll(),
90 already_open_issues[0])
Ben Pasteneca7c71b2021-10-07 18:34:27 -070091 escaped_quotes = urllib.parse.quote('"')
92 message = mock_query.call_args.kwargs['message']
93 self.assertEqual(message.count(escaped_quotes), 2)
94 self.assertTrue(message.startswith(escaped_quotes))
95 self.assertTrue(message.endswith(escaped_quotes))
Ben Pastene6a8361a2021-08-19 19:52:05 -070096 already_open_issues = [123456, 654321]
97 with mock.patch.object(
98 self.committer._gerrit_helper, 'Query',
99 return_value=already_open_issues):
100 self.assertRaises(
101 chrome_chromeos_lkgm.LKGMNotValid,
102 self.committer.FindAlreadyOpenLKGMRoll)
103
104 def testSubmitToCQ(self):
Ben Pastene33da0c22021-11-29 21:14:05 -0800105 self.committer._buildbucket_id = 'some-build-id'
Ben Pastene6a8361a2021-08-19 19:52:05 -0700106 already_open_issue = 123456
Ben Pastene33da0c22021-11-29 21:14:05 -0800107 with mock.patch.object(
108 self.committer._gerrit_helper, 'SetReview') as mock_review:
Ben Pastene6a8361a2021-08-19 19:52:05 -0700109 self.committer.SubmitToCQ(already_open_issue)
Ben Pastene33da0c22021-11-29 21:14:05 -0800110 self.assertIn(
111 self.committer._buildbucket_id, mock_review.call_args[1]['msg'])