commit f9c736cb32b85b1531ea8623bcca2462ee2dc612
author Tiancong Wang <tcwang@google.com> Mon Aug 26 13:54:38 2019 -0700
committer Commit Bot <commit-bot@chromium.org> Fri Sep 06 22:34:02 2019 +0000
tree 11cbd903e7fbfc91c664b6cf6f94cb27bb016c9c
parent 822e5f1dfd24edd1b30bec02168b6afc3005b9a2

afdo: Implement chrome-release-afdo-verify builder.

This patch implements a builder to verify the most recent
Chrome afdo profiles (benchmark and CWP). Once verified
that Chrome can be built, it publishes the new profiles
to metadata for PUpr to pick them up.

The patch mostly reuses the functionalities for kernel
afdo verification builder.

BUG=chromium:990855
TEST=https://ci.chromium.org/p/chromeos/builders/general/Try/b8903115280723980960

Change-Id: I16328ac9ea1937183e6066ec199c01e8d03773d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1782961
Tested-by: Tiancong Wang <tcwang@google.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Tiancong Wang <tcwang@google.com>

api/controller/toolchain_unittest.py

diff --git a/api/controller/toolchain_unittest.py b/api/controller/toolchain_unittest.py
index 7d66651..709b379 100644
--- a/api/controller/toolchain_unittest.py
+++ b/api/controller/toolchain_unittest.py
@@ -32,6 +32,8 @@
         toolchain_util, 'OrderfileUpdateChromeEbuild', return_value=True)
     self.kernel_command = self.PatchObject(
         toolchain_util, 'AFDOUpdateKernelEbuild', return_value=True)
+    self.chrome_command = self.PatchObject(
+        toolchain_util, 'AFDOUpdateChromeEbuild', return_value=True)
     self.PatchObject(cros_build_lib, 'Die', new=self.mock_die)
 
   def _GetRequest(self, build_target=None, artifact_type=None):
@@ -67,6 +69,7 @@
                                             self.api_config)
     self.orderfile_command.assert_called_once_with(self.board)
     self.kernel_command.assert_not_called()
+    self.chrome_command.assert_not_called()
 
   def testKernelAFDOSuccess(self):
     """Test the command is called correctly with kernel afdo."""
@@ -76,10 +79,20 @@
                                             self.api_config)
     self.kernel_command.assert_called_once_with(self.board)
     self.orderfile_command.assert_not_called()
+    self.chrome_command.assert_not_called()
+
+  def testChromeAFDOSuccess(self):
+    """Test the command is called correctly with Chrome afdo."""
+    request = self._GetRequest(
+        build_target=self.board, artifact_type=toolchain_pb2.CHROME_AFDO)
+    toolchain.UpdateEbuildWithAFDOArtifacts(request, self.response,
+                                            self.api_config)
+    self.chrome_command.assert_called_once_with(self.board)
+    self.orderfile_command.assert_not_called()
+    self.kernel_command.assert_not_called()
 
 
-class UploadVettedFDOArtifactsTest(
-    UpdateEbuildWithAFDOArtifactsTest):
+class UploadVettedFDOArtifactsTest(UpdateEbuildWithAFDOArtifactsTest):
   """Unittests for UploadVettedAFDOArtifacts."""
 
   @staticmethod
@@ -127,3 +140,10 @@
         build_target=self.board, artifact_type=toolchain_pb2.KERNEL_AFDO)
     toolchain.UploadVettedAFDOArtifacts(request, self.response, self.api_config)
     self.command.assert_called_once_with('kernel_afdo', self.board)
+
+  def testChromeAFDOSuccess(self):
+    """Test the command is called correctly with Chrome afdo."""
+    request = self._GetRequest(
+        build_target=self.board, artifact_type=toolchain_pb2.CHROME_AFDO)
+    toolchain.UploadVettedAFDOArtifacts(request, self.response, self.api_config)
+    self.command.assert_called_once_with('chrome_afdo', self.board)