commit f877da277b2296f4bf366b7f5e8af7d3761075b9
author Achuith Bhandarkar <achuith@chromium.org> Tue Sep 12 12:27:39 2017 -0700
committer chrome-bot <chrome-bot@chromium.org> Tue Sep 12 18:16:30 2017 -0700
tree f51ec7be1716e40c6a5dd262386dc8c4c73db179
parent 9f8d1eae35fe18943c75ec8e5c17af54c443b916

cros_vm: Disable sudo if /dev/kvm is writeable.

BUG=chromium:591624
TEST=manual

Change-Id: I563e56edc4d452adf27179c1f2bc314da562b914
Reviewed-on: https://chromium-review.googlesource.com/664062
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

scripts/cros_vm.py

diff --git a/scripts/cros_vm.py b/scripts/cros_vm.py
index ee414c7..14685dd 100644
--- a/scripts/cros_vm.py
+++ b/scripts/cros_vm.py
@@ -44,8 +44,9 @@
 
     self.qemu_path = qemu_path
     self.enable_kvm = enable_kvm
-    # Software emulation doesn't need sudo access.
-    self.use_sudo = enable_kvm
+    # We don't need sudo access for software emulation or if /dev/kvm is
+    # writeable.
+    self.use_sudo = enable_kvm and not os.access('/dev/kvm', os.W_OK)
     self.display = display
     self.image_path = image_path
     self.ssh_port = ssh_port