commit f8102c5a787b2fc6490be39dbf78bb748ffd6e70
author Mike Frysinger <vapier@chromium.org> Tue Dec 10 00:27:56 2019 -0500
committer Commit Bot <commit-bot@chromium.org> Tue Dec 10 20:25:36 2019 +0000
tree 2891241724e88a2c4c480b1cba5e3d958844205f
parent 9dbfb338d0b6da769c5be3f2b2efb89c720927c6

cros_generate_android_breakpad_symbols: fix encoding handling

We capture output here so make sure it's UTF-8 for parsing.

BUG=chromium:997354
TEST=`./run_tests` passes

Change-Id: I91c850a559022c5992b887de8d626df9579862d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1959370
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

scripts/cros_generate_android_breakpad_symbols.py

diff --git a/scripts/cros_generate_android_breakpad_symbols.py b/scripts/cros_generate_android_breakpad_symbols.py
index 9ac7aab..976f17e 100644
--- a/scripts/cros_generate_android_breakpad_symbols.py
+++ b/scripts/cros_generate_android_breakpad_symbols.py
@@ -138,7 +138,7 @@
   # packed binaries.).
   unpack_cmd = [RELOCATION_PACKER_BIN, '-u', elf_file]
   unpack_result = cros_build_lib.run(
-      unpack_cmd, redirect_stdout=True, error_code_ok=True)
+      unpack_cmd, stdout=True, check=False, encoding='utf8')
 
   # If we unpacked, extract the offset, and remember it.
   offset = FindExpansionOffset(unpack_result)