commit f624bf46377ad9e9802712751f013402039bde18
author Brian Norris <briannorris@chromium.org> Thu Mar 02 12:57:49 2023 -0800
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 24 21:40:03 2023 +0000
tree 33ef2d1f04b1f2701047dbd4a03e7d429c02b1a2
parent 8d132fb78a5a4ee2cd12cda7116674c604015bff

cros_sdk: Drop --unmount

This was associated with the --use-image feature, which we're dropping.

Leave the BAPI as a no-op.

BUG=b:266878468
TEST=./run_tests

Change-Id: If472a3d8d221ef8d3e0755c66acc7419282dad89
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4305423
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>

api/controller/sdk_unittest.py

diff --git a/api/controller/sdk_unittest.py b/api/controller/sdk_unittest.py
index 5cf8489..67333ee 100644
--- a/api/controller/sdk_unittest.py
+++ b/api/controller/sdk_unittest.py
@@ -177,6 +177,17 @@
         patch.assert_called_once_with(mock.ANY, force=True)
 
 
+class SdkUnmountTest(cros_test_lib.MockTestCase, api_config.ApiConfigMixin):
+    """SDK Unmount tests."""
+
+    def testNoop(self):
+        """Unmount is a deprecated noop."""
+        request = sdk_pb2.UnmountRequest()
+        response = sdk_pb2.UnmountResponse()
+        rc = sdk_controller.Unmount(request, response, self.api_config)
+        self.assertFalse(rc)
+
+
 class SdkUnmountPathTest(cros_test_lib.MockTestCase, api_config.ApiConfigMixin):
     """Update tests."""