commit f5a3b2d93548c83fc090cdf7b61d723b22716d3b
author Mike Frysinger <vapier@chromium.org> Thu Dec 12 14:36:17 2019 -0500
committer Commit Bot <commit-bot@chromium.org> Tue Dec 17 07:19:59 2019 +0000
tree 298a39fa2f13f0ef574a3dd80d76eae9eef020e2
parent e4191fcb9d1119b108cebfa04522ea2787cb64f5

cros_build_lib.run: clean up error_code_ok->check migration

BUG=chromium:1006587
TEST=`./run_tests` passes

Change-Id: Ie416c5f7b16314a34a3a53f503469b3cc93fb9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1965957
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>

scripts/cros_sdk_unittest.py

diff --git a/scripts/cros_sdk_unittest.py b/scripts/cros_sdk_unittest.py
index 3185ec9..d2632ac 100644
--- a/scripts/cros_sdk_unittest.py
+++ b/scripts/cros_sdk_unittest.py
@@ -37,21 +37,21 @@
     """Check for commands from the lvm2 package."""
     with sudo.SudoKeepAlive():
       cmd = ['lvs', '--version']
-      result = cros_build_lib.run(cmd, error_code_ok=True)
+      result = cros_build_lib.run(cmd, check=False)
       self.assertEqual(result.returncode, 0)
 
   def testThinProvisioningToolsPresent(self):
     """Check for commands from the thin-provisioning-tools package."""
     with sudo.SudoKeepAlive():
       cmd = ['thin_check', '-V']
-      result = cros_build_lib.run(cmd, error_code_ok=True)
+      result = cros_build_lib.run(cmd, check=False)
       self.assertEqual(result.returncode, 0)
 
   def testLosetupCommandPresent(self):
     """Check for commands from the mount package."""
     with sudo.SudoKeepAlive():
       cmd = ['losetup', '--help']
-      result = cros_build_lib.run(cmd, error_code_ok=True)
+      result = cros_build_lib.run(cmd, check=False)
       self.assertEqual(result.returncode, 0)
 
 
@@ -118,7 +118,7 @@
 
     try:
       result = cros_build_lib.run(
-          cmd, print_cmd=False, capture_output=True, error_code_ok=True,
+          cmd, print_cmd=False, capture_output=True, check=False,
           combine_stdout_stderr=True)
     except cros_build_lib.RunCommandError as e:
       raise SystemExit('Running %r failed!: %s' % (cmd, e))