cros_build_lib.run: clean up error_code_ok->check migration
BUG=chromium:1006587
TEST=`./run_tests` passes
Change-Id: Ie416c5f7b16314a34a3a53f503469b3cc93fb9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1965957
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>
diff --git a/scripts/cbuildbot_launch.py b/scripts/cbuildbot_launch.py
index b3f54fc..c1038ce 100644
--- a/scripts/cbuildbot_launch.py
+++ b/scripts/cbuildbot_launch.py
@@ -410,7 +410,7 @@
with boto_compat.FixBotoCerts(activate=fix_boto):
result = cros_build_lib.run(
- cmd, extra_env=extra_env, error_code_ok=True, cwd=buildroot)
+ cmd, extra_env=extra_env, check=False, cwd=buildroot)
return result.returncode
@@ -430,10 +430,10 @@
except timeout_util.TimeoutError:
logging.exception('Cleaning up chroot timed out')
# Dump debug info to help https://crbug.com/1000034.
- cros_build_lib.run(['mount'], error_code_ok=False)
- cros_build_lib.run(['uname', '-a'], error_code_ok=False)
- cros_build_lib.sudo_run(['losetup', '-a'], error_code_ok=False)
- cros_build_lib.run(['dmesg'], error_code_ok=False)
+ cros_build_lib.run(['mount'], check=True)
+ cros_build_lib.run(['uname', '-a'], check=True)
+ cros_build_lib.sudo_run(['losetup', '-a'], check=True)
+ cros_build_lib.run(['dmesg'], check=True)
logging.warning('Assuming the bot is going to reboot, so ignoring this '
'failure; see https://crbug.com/1000034')