commit f5a3b2d93548c83fc090cdf7b61d723b22716d3b
author Mike Frysinger <vapier@chromium.org> Thu Dec 12 14:36:17 2019 -0500
committer Commit Bot <commit-bot@chromium.org> Tue Dec 17 07:19:59 2019 +0000
tree 298a39fa2f13f0ef574a3dd80d76eae9eef020e2
parent e4191fcb9d1119b108cebfa04522ea2787cb64f5

cros_build_lib.run: clean up error_code_ok->check migration

BUG=chromium:1006587
TEST=`./run_tests` passes

Change-Id: Ie416c5f7b16314a34a3a53f503469b3cc93fb9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1965957
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chris McDonald <cjmcdonald@chromium.org>

api/compile_build_api_proto.py

diff --git a/api/compile_build_api_proto.py b/api/compile_build_api_proto.py
index 944efc9..9e48db2 100644
--- a/api/compile_build_api_proto.py
+++ b/api/compile_build_api_proto.py
@@ -105,7 +105,7 @@
 
   cmd = [_PROTOC, '--python_out', output, '--proto_path', source] + targets
   result = cros_build_lib.run(
-      cmd, cwd=source, print_cmd=False, error_code_ok=True)
+      cmd, cwd=source, print_cmd=False, check=False)
 
   if result.returncode:
     raise GenerationError('Error compiling the proto. See the output for a '