commit f2c1d7931ca5a1dd99b1e4531d24cea5175d7889
author Ralph Nathan <ralphnathan@chromium.org> Tue May 05 17:16:15 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Fri May 08 02:00:51 2015 +0000
tree 7930570ebf8f9bd79d9dd8f5d8303f61953b80ea
parent a5ddff101dbae52011e80950354bf47bae8c03d2

brillo flash: Display progress bar at notice level for usb.

When flashing to a usb device, display the progress bar (using
pv) at logging level notice inside the chroot.

BUG=brillo:994
TEST=`cros flash usb:// IMAGE --log-level notice`

Change-Id: I284a4a557a28ae35944e36ee23179204b9e521b4
Reviewed-on: https://chromium-review.googlesource.com/269603
Reviewed-by: David Pursell <dpursell@chromium.org>
Commit-Queue: Ralph Nathan <ralphnathan@chromium.org>
Trybot-Ready: Ralph Nathan <ralphnathan@chromium.org>
Tested-by: Ralph Nathan <ralphnathan@chromium.org>

cli/flash.py

diff --git a/cli/flash.py b/cli/flash.py
index 88a4505..6d6f68d 100644
--- a/cli/flash.py
+++ b/cli/flash.py
@@ -166,7 +166,12 @@
 
     cmd = '%s %s | dd of=%s bs=4M iflag=fullblock oflag=sync' % (
         cmd_base, image, device)
-    cros_build_lib.SudoRunCommand(cmd, shell=True)
+
+    # We want to display the output at logging level NOTICE or less but we only
+    # want to print the command at logging levels INFO and DEBUG.
+    cros_build_lib.SudoRunCommand(
+        cmd, shell=True, debug_level=logging.NOTICE,
+        print_cmd=logging.getLogger().getEffectiveLevel() < logging.NOTICE)
     cros_build_lib.SudoRunCommand(['sync'], debug_level=self.debug_level)