commit eb76da70dcacd18abb6f9a1cc57873876fdaf7e0
author Alex Klein <saklein@chromium.org> Fri Mar 19 10:43:09 2021 -0600
committer Commit Bot <commit-bot@chromium.org> Fri Apr 09 16:16:58 2021 +0000
tree fe3162692256e1cd42b48fa3fe59ff88d51aee82
parent d4ca83ce1cb75cc7bd3b66e5e43ac664c1583b6d

controller/sysroot: Skip setup board in InstallPackages

Skip setup_board in build_packages for builders. Allows configuring
the sysroot only in Sysroot/Create, and eventually simplifying the
InstallPackages request.

BUG=chromium:945003
TEST=cq

Change-Id: I55e18a64ccc3eb938526248fa6320475a283a312
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/2774608
Tested-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

api/controller/sysroot_unittest.py

diff --git a/api/controller/sysroot_unittest.py b/api/controller/sysroot_unittest.py
index 50b9c9e..605e99e 100644
--- a/api/controller/sysroot_unittest.py
+++ b/api/controller/sysroot_unittest.py
@@ -605,13 +605,17 @@
     rc = sysroot_controller.InstallPackages(in_proto, out_proto,
                                             self.api_config)
     self.assertFalse(rc)
-    rc_patch.assert_called_with(usepkg=True, install_debug_symbols=True,
-                                packages=[],
-                                package_indexes=[
-                                    binpkg.PackageIndexInfo.from_protobuf(x)
-                                    for x in package_indexes
-                                ], use_flags=[], use_goma=False,
-                                incremental_build=False)
+    rc_patch.assert_called_with(
+        usepkg=True,
+        install_debug_symbols=True,
+        packages=[],
+        package_indexes=[
+            binpkg.PackageIndexInfo.from_protobuf(x) for x in package_indexes
+        ],
+        use_flags=[],
+        use_goma=False,
+        incremental_build=False,
+        setup_board=False)
 
   def testSuccessWithGomaLogs(self):
     """Test successful call with goma."""