Stop building and installing the 'chrome-sandbox' binary.
The 'chrome-sandbox' binary has not been used for Chrome sandboxing in
a while. Recently vapier@ removed its setuid bit. Given that nothing
broke at that time (without the setuid bit the 'chrome-sandbox' binary
is useless), it's time to remove it from the build.
BUG=chromium:929824
TEST=Unit tests pass.
TEST=Rename binary on DUT, restart UI, browser loads.
TEST=chrome:sandbox prints the right things.
TEST=Patch this in the Chromium source tree, deploy Chrome.
Change-Id: Ib691f97802a238c5e137646ea8ac2cb7a0deed6a
Reviewed-on: https://chromium-review.googlesource.com/1459677
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
diff --git a/scripts/deploy_chrome.py b/scripts/deploy_chrome.py
index 89f43cc..2d63bcf 100644
--- a/scripts/deploy_chrome.py
+++ b/scripts/deploy_chrome.py
@@ -269,7 +269,7 @@
if not self.device.HasRsync():
raise DeployFailure(
'rsync is not found on the device.\n'
- 'Run dev_install on the device to get rsync installed')
+ 'Run dev_install on the device to get rsync installed.')
self.device.CopyToDevice('%s/' % os.path.abspath(self.staging_dir),
self.options.target_dir,
mode='rsync', inplace=True,