Stop building and installing the 'chrome-sandbox' binary.
The 'chrome-sandbox' binary has not been used for Chrome sandboxing in
a while. Recently vapier@ removed its setuid bit. Given that nothing
broke at that time (without the setuid bit the 'chrome-sandbox' binary
is useless), it's time to remove it from the build.
BUG=chromium:929824
TEST=Unit tests pass.
TEST=Rename binary on DUT, restart UI, browser loads.
TEST=chrome:sandbox prints the right things.
TEST=Patch this in the Chromium source tree, deploy Chrome.
Change-Id: Ib691f97802a238c5e137646ea8ac2cb7a0deed6a
Reviewed-on: https://chromium-review.googlesource.com/1459677
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
diff --git a/scripts/cros_gdb.py b/scripts/cros_gdb.py
index 15e6b89..8e63221 100644
--- a/scripts/cros_gdb.py
+++ b/scripts/cros_gdb.py
@@ -365,10 +365,8 @@
if pname == 'browser':
all_chrome_pids = set(device.GetRunningPids(
'/opt/google/chrome/chrome'))
- sandbox_pids = set(device.GetRunningPids(
- '/opt/google/chrome/chrome-sandbox'))
non_main_chrome_pids = set(device.GetRunningPids('type='))
- pids = list(all_chrome_pids - sandbox_pids - non_main_chrome_pids)
+ pids = list(all_chrome_pids - non_main_chrome_pids)
elif pname == 'renderer' or pname == 'gpu-process':
pids = device.GetRunningPids('type=%s'% pname)
else: