commit ea02aa1b6a18a147677bb596cfcb656b404d7c81
author Brian Norris <briannorris@chromium.org> Mon May 01 15:24:58 2023 -0700
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 03 19:23:08 2023 +0000
tree 03e6633cbe01007b51ce00388c0fe1d06d6d3a29
parent 2712b4002d181880cdfdb5bd1818b4d273231ac6

lib: chroot_lib: Predicate existence on out_path

Common usages of this method assume some basic filesystem hierarchy
exists, including the ability to utilize tempdir(). Because tempdir()
will be within out_path, let's start asserting its existence too.

This should produce less cryptic failure modes in cases where we fail
this assumption.

BUG=b:265885353
TEST=./run_tests

Change-Id: I981410951dfcfc793a991bd04d1855aa8fa50485
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4497446
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>

api/controller/artifacts_unittest.py

diff --git a/api/controller/artifacts_unittest.py b/api/controller/artifacts_unittest.py
index 082a799..faf7ab0 100644
--- a/api/controller/artifacts_unittest.py
+++ b/api/controller/artifacts_unittest.py
@@ -91,6 +91,7 @@
             self.chroot_path, self.sysroot_path.lstrip(os.sep)
         )
         osutils.SafeMakedirs(full_sysroot_path)
+        osutils.SafeMakedirs(self.chroot_out_path)
 
         # All requests use same response type.
         self.response = artifacts_pb2.BundleResponse()