commit e2612a0c0fd19ded0bf7d63237faba04d381f62d
author Alex Klein <saklein@chromium.org> Thu Apr 18 13:51:06 2019 -0600
committer chrome-bot <chrome-bot@chromium.org> Fri Apr 19 14:45:32 2019 -0700
tree f6e46168accfbbf1f1220a7896dcd0b2d9327f35
parent 926dd12515776fa23d3bf576cc528d4ec1e03073

controller/artifacts: Updated todos to reference bugs.

BUG=None
TEST=None

Change-Id: I01a78b5a8f60085d2ff625ceff7503d0a94b13e6
Reviewed-on: https://chromium-review.googlesource.com/1574482
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>

api/controller/artifacts.py

diff --git a/api/controller/artifacts.py b/api/controller/artifacts.py
index aabd513..8ffa8f4 100644
--- a/api/controller/artifacts.py
+++ b/api/controller/artifacts.py
@@ -18,6 +18,8 @@
 def _GetImageDir(build_root, target):
   """Return path containing images for the given build target.
 
+  TODO(saklein) Expand image_lib.GetLatestImageLink to support this use case.
+
   Args:
     build_root (str): Path to checkout where build occurs.
     target (str): Name of the build target.
@@ -82,7 +84,7 @@
   # a list of generated files. As a workaround, we have commands.py
   # put the files in a separate temporary directory so we can catalog them,
   # then move them to the output dir.
-  # TODO(saklein): Repalce with a chromite/service implementation.
+  # TODO(crbug.com/954283): Replace with a chromite/service implementation.
   with osutils.TempDir() as temp:
     commands.GeneratePayloads(img, temp, full=True, stateful=True, delta=True)
     commands.GenerateQuickProvisionPayloads(img, temp)
@@ -107,7 +109,7 @@
 
   # Note that unlike the functions below, this returns the full path
   # to *multiple* tarballs.
-  # TODO(saklein): Replace with a chromite/service implementation.
+  # TODO(crbug.com/954289): Replace with a chromite/service implementation.
   archives = commands.BuildAutotestTarballsForHWTest(build_root, cwd,
                                                      output_dir)
 
@@ -129,7 +131,7 @@
 
   # Note that unlike the functions below, this returns the full path
   # to the tarball.
-  # TODO(saklein): Replace with a chromite/service implementation.
+  # TODO(crbug.com/954294): Replace with a chromite/service implementation.
   archive = commands.BuildTastBundleTarball(build_root, cwd, output_dir)
 
   if archive is None:
@@ -151,7 +153,7 @@
   output_dir = input_proto.output_dir
   build_root = constants.SOURCE_ROOT
 
-  # TODO(saklein): Replace with a chromite/service implementation.
+  # TODO(crbug.com/954299): Replace with a chromite/service implementation.
   archive = commands.BuildPinnedGuestImagesTarball(build_root, target,
                                                    output_dir)
 
@@ -174,7 +176,7 @@
   output_dir = input_proto.output_dir
   build_root = constants.SOURCE_ROOT
 
-  # TODO(saklein): Replace with a chromite/service implementation.
+  # TODO(crbug.com/954300): Replace with a chromite/service implementation.
   archive = commands.BuildFirmwareArchive(build_root, target, output_dir)
 
   if archive is None:
@@ -198,7 +200,7 @@
   # Adjust accordingly...
   build_root = os.path.join(constants.SOURCE_ROOT, 'chroot', 'build')
 
-  # TODO(saklein): Replace with a chromite/service implementation.
+  # TODO(crbug.com/954303): Replace with a chromite/service implementation.
   archive = commands.BuildEbuildLogsTarball(build_root, target, output_dir)
 
   if archive is None: