commit df8ee500273b2d1b125eea783536f9ada03d7b2a
author Alex Klein <saklein@chromium.org> Tue Oct 18 09:48:15 2022 -0600
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Oct 19 18:46:15 2022 +0000
tree 28337e76ee8bbb816247cc9a4c32ed0edf66be22
parent 1f5e3ea7991aaeac8e85404fe9f262494a46b1b8

cros_build_lib.Die lazy formatting.

nitty fix: Switch calls to cros_build_lib.Die to use lazy formatting
rather than formatting the string being passed.

BUG=None
TEST=run_tests

Change-Id: Id8e3f5df94dd602eb2a431d73f4d84e04d5d2a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/3964308
Reviewed-by: Ram Chandrasekar <rchandrasekar@google.com>
Commit-Queue: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Auto-Submit: Alex Klein <saklein@chromium.org>

scripts/cros_generate_tidy_warnings.py

diff --git a/scripts/cros_generate_tidy_warnings.py b/scripts/cros_generate_tidy_warnings.py
index 39c1275..71728cf 100644
--- a/scripts/cros_generate_tidy_warnings.py
+++ b/scripts/cros_generate_tidy_warnings.py
@@ -93,7 +93,7 @@
     """Run environment dependent checks on parsed args."""
     target = os.path.join(options.out_dir, options.out_file)
     if os.path.exists(target):
-        cros_build_lib.Die("Output file %r already exists." % target)
+        cros_build_lib.Die("Output file %r already exists.", target)
 
     if not os.path.isdir(options.out_dir):
         cros_build_lib.Die(