api: test & image: detect and handle artifact failures
BUG=b:255838545
TEST=run_tests
Change-Id: I9b63d2ac4c32c73b26eb971e974b0c20373eb0b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4068814
Reviewed-by: Jack Neus <jackneus@google.com>
Commit-Queue: Josiah Hounyo <josiahh@google.com>
Tested-by: Josiah Hounyo <josiahh@google.com>
Reviewed-by: Chris Gerber <gerb@google.com>
diff --git a/api/controller/image.py b/api/controller/image.py
index 5961943..a510434 100644
--- a/api/controller/image.py
+++ b/api/controller/image.py
@@ -13,6 +13,7 @@
import os
from pathlib import Path
import time
+import traceback
from typing import List, NamedTuple, Set, TYPE_CHECKING, Union
from chromite.api import controller
@@ -213,7 +214,28 @@
for output_artifact in in_proto.output_artifacts:
for artifact_type, func in artifact_types.items():
if artifact_type in output_artifact.artifact_types:
- result = func(output_dir)
+ try:
+ result = func(output_dir)
+ except Exception as e:
+ generated.append(
+ {
+ "type": artifact_type,
+ "failed": True,
+ "failure_reason": str(e),
+ }
+ )
+ artifact_name = (
+ common_pb2.ArtifactsByService.Image.ArtifactType.Name(
+ artifact_type
+ )
+ )
+ logging.warning(
+ "%s artifact generation failed with exception %s",
+ artifact_name,
+ e,
+ )
+ logging.warning("traceback:\n%s", traceback.format_exc())
+ continue
if result:
generated.append(
{