loman: optionally set revision element
since ElementTree doesn't know how to make an element with "None",
only create the revision attribute if it is not None.
BUG=chromium-os:33688
TEST=verified that a remote project with and without revisions works
Change-Id: I568a9e2821a1c089a0ba391f6df6c0e3b2dc61c9
Signed-off-by: Rhyland Klein <rklein@nvidia.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/32393
Commit-Ready: Brian Harring <ferringb@chromium.org>
Reviewed-by: Brian Harring <ferringb@chromium.org>
Tested-by: Brian Harring <ferringb@chromium.org>
diff --git a/scripts/loman.py b/scripts/loman.py
index 7d04b7f..2408eb3 100644
--- a/scripts/loman.py
+++ b/scripts/loman.py
@@ -32,8 +32,10 @@
def AddNonWorkonProject(self, name, path, remote=None, revision=None):
"""Add a new nonworkon project element to the manifest tree."""
element = ElementTree.Element('project', name=name, path=path,
- remote=remote, revision=revision)
+ remote=remote)
element.attrib['workon'] = 'False'
+ if revision is not None:
+ element.attrib['revision'] = revision
self.nodes.append(element)
return element