commit d668a22b52b77a24d4f2d5cfabd0cd6da08a36ee
author Mike Frysinger <vapier@chromium.org> Mon Sep 11 23:51:55 2023 -0400
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 12 16:14:17 2023 +0000
tree 41260720468d54fc9d37fe1cea9c8bffe43a125e
parent 3def90dabdc7cadd5f009398f7190c4824905bb0

api: binhost: use throw away bucket for tests

This code doesn't actually access the bucket, but since it's not a
real one even though it looks like it might/could be, switch to the
trash bucket to avoid confusion.

BUG=chromium:1481176
TEST=CQ passes

Change-Id: I4f7e6a96f2b6849849c675d93709f6b864093a24
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4856684
Commit-Queue: Alex Klein <saklein@chromium.org>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

api/controller/binhost.py

diff --git a/api/controller/binhost.py b/api/controller/binhost.py
index 8d9f533..44554bf 100644
--- a/api/controller/binhost.py
+++ b/api/controller/binhost.py
@@ -41,7 +41,7 @@
     """Add fake binhosts to a successful response."""
     new_binhost = output_proto.binhosts.add()
     new_binhost.uri = (
-        "gs://cr-prebuilt/board/amd64-generic/"
+        f"{constants.TRASH_BUCKET}/board/amd64-generic/"
         "paladin-R66-17.0.0-rc2/packages/"
     )
     new_binhost.package_index = "Packages"

api/controller/binhost_unittest.py

diff --git a/api/controller/binhost_unittest.py b/api/controller/binhost_unittest.py
index c4384c8..343ed33 100644
--- a/api/controller/binhost_unittest.py
+++ b/api/controller/binhost_unittest.py
@@ -53,8 +53,8 @@
         """GetBinhosts calls service with correct args."""
         # pylint: disable=line-too-long
         binhost_list = [
-            "gs://cr-prebuilt/board/amd64-generic/paladin-R66-17.0.0-rc2/packages/",
-            "gs://cr-prebuilt/board/eve/paladin-R66-17.0.0-rc2/packages/",
+            f"{constants.TRASH_BUCKET}/board/amd64-generic/paladin-R66-17.0.0-rc2/packages/",
+            f"{constants.TRASH_BUCKET}/board/eve/paladin-R66-17.0.0-rc2/packages/",
         ]
         # pylint: enable=line-too-long
         get_binhost = self.PatchObject(