commit d62b06da0706f08386d8488416fbd56ea3d0bfd8
author Mike Frysinger <vapier@chromium.org> Thu Aug 31 15:06:16 2023 -0400
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Aug 31 21:14:40 2023 +0000
tree 65c2a48ee584eb952febe0c86f8cc558cc2460db
parent 1b959cc3d5ebade0be195ce95fee0c7f6c9eb9ec

scripts: deploy_chrome: work around broken remote access quoting

The remote access module doesn't properly quote command lists, so until
we can fix that, use a shell buffer here with embedded quoting.

BUG=b:289176310
TEST=CQ passes

Change-Id: I6c160c4a49e73976479c96ffb41e4d2ebd428e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4833293
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>

scripts/deploy_chrome.py

diff --git a/scripts/deploy_chrome.py b/scripts/deploy_chrome.py
index 4250c2a..d42f7d6 100644
--- a/scripts/deploy_chrome.py
+++ b/scripts/deploy_chrome.py
@@ -234,14 +234,14 @@
         )
         # Running in VMs cause make_dev_ssd's firmware confidence checks to
         # fail. Use --force to bypass the checks.
-        cmd = [
-            "/usr/share/vboot/bin/make_dev_ssd.sh",
-            "--partitions",
-            f"{KERNEL_A_PARTITION} {KERNEL_B_PARTITION}",
-            "--remove_rootfs_verification",
-            "--force",
-        ]
-        self.device.run(cmd, check=False)
+        # TODO(b/269266992): Switch back to a list.
+        cmd = (
+            "/usr/share/vboot/bin/make_dev_ssd.sh "
+            f"--partitions '{KERNEL_A_PARTITION} {KERNEL_B_PARTITION}' "
+            "--remove_rootfs_verification "
+            "--force"
+        )
+        self.device.run(cmd, shell=True, check=False)
 
         self.device.Reboot()