commit d401e5a3b910a5d57e22838cb6c99d5c82643a4b
author Greg Edelston <gredelston@google.com> Fri Apr 28 15:29:11 2023 -0600
committer Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 02 00:29:04 2023 +0000
tree 12884e41a9daf293feb85993a971ae8a80ff6374
parent a3b743837caed89419d500fff78dbfca8cd013fa

service: Uprev host prebuilts file too

BUG=b:259445595
TEST=./run_tests

Change-Id: Ia1e488aa6931de748f222d1c36fc4b7f64854922
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/4493224
Commit-Queue: Greg Edelston <gredelston@google.com>
Tested-by: Greg Edelston <gredelston@google.com>
Commit-Queue: Alex Klein <saklein@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>
Auto-Submit: Greg Edelston <gredelston@google.com>

api/controller/sdk.py

diff --git a/api/controller/sdk.py b/api/controller/sdk.py
index c58b160..d4c2ace 100644
--- a/api/controller/sdk.py
+++ b/api/controller/sdk.py
@@ -5,7 +5,6 @@
 """SDK chroot operations."""
 
 import os
-import pathlib
 from typing import Dict, Union
 
 from chromite.api import controller
@@ -179,9 +178,7 @@
 
 
 @faux.all_empty
-@validate.require("source_root")
 @validate.require("binhost_gs_bucket")
-@validate.eq("source_root.location", common_pb2.Path.Location.OUTSIDE)
 @validate.validation_complete
 def Uprev(input_proto, output_proto, _config):
     """Update SDK version file and prebuilt files to point to the latest SDK.
@@ -191,11 +188,12 @@
     # If the UprevRequest did not specify a target version,
     # check the remote SDK version file on Google Cloud Storage for the latest
     # uprev target.
-    target_version = input_proto.version or sdk.GetLatestUprevTargetVersion()
+    target_version = (
+        input_proto.version or sdk.get_latest_uprev_target_version()
+    )
 
     # The main uprev logic occurs in service/sdk.py.
-    modified_files = sdk.UprevSdkAndPrebuilts(
-        pathlib.Path(input_proto.source_root.path),
+    modified_files = sdk.uprev_sdk_and_prebuilts(
         binhost_gs_bucket=input_proto.binhost_gs_bucket,
         version=target_version,
     )